Open
Conversation
tvdeyen
approved these changes
May 23, 2017
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Great! (besides the weird Bundler issues in the CI builds)
alepore
force-pushed
the
login_translations
branch
2 times, most recently
from
19055a8 to
de3a7b1
Compare
tvdeyen
approved these changes
Jun 2, 2017
Member
|
🚢 |
Member
|
@alepore could you please rebase |
alepore
force-pushed
the
login_translations
branch
from
de3a7b1 to
f692dbb
Compare
Member
|
@alepore sorry, can you rebase again (last time)? I’m going to merge as soon as specs pass. Thanks! |
alepore
force-pushed
the
login_translations
branch
from
f692dbb to
e182519
Compare
Contributor
Author
|
😭 |
Now login/sign up/password recover pages form solidus_auth_devise are translated.
v2.x is required for Solidus 2.5+
alepore
force-pushed
the
login_translations
branch
from
750eb90 to
7df24ef
Compare
Contributor
Author
|
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SolidusI18n::ControllerLocaleHelpermodule is required to translate pages.This is included on
Spree::BaseControllerbut not on thesolidus_auth_devisecontrollers.This PR adds the module to the missing controllers.
Closes #10