Fix all_products_except to exclude unavailable products#432
Open
rafaelmerlotto wants to merge 2 commits intosolidusio:mainfrom
Open
Fix all_products_except to exclude unavailable products#432rafaelmerlotto wants to merge 2 commits intosolidusio:mainfrom
rafaelmerlotto wants to merge 2 commits intosolidusio:mainfrom
Conversation
jarednorman
requested changes
Nov 16, 2025
Member
jarednorman
left a comment
There was a problem hiding this comment.
I think we should use the available scope.
Author
|
Thanks for the feedback. Using This ensures the method returns only true available products in the section You May Also Like. |
jarednorman
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
all_products_except(product_ids)method in theTaxonCustomQueriesmodule was returning products withavailable_onset tonil. This caused products that are not yet available to show in "You May Also Like" section on the product page.Solution:
Updated the method to exclude products with
available_on = nil