Skip to content

Fix CI#438

Draft
AlistairNorman wants to merge 12 commits intosolidusio:mainfrom
SuperGoodSoft:fix-github-actions
Draft

Fix CI#438
AlistairNorman wants to merge 12 commits intosolidusio:mainfrom
SuperGoodSoft:fix-github-actions

Conversation

@AlistairNorman
Copy link
Contributor

@AlistairNorman AlistairNorman commented Feb 12, 2026 •
edited
Loading

Summary

Now that we have GitHub actions running we debugged several issues that were uncovered.

  • Lock state machines to an older version as in Solidus and all of the extensions due to the Stack Level too Deep error
  • Add database services to test yml file as in this commit in solidus subscriptions
  • Remove versions of Ruby/Rails/Solidus except the newest release of Solidus, main, and the newest Ruby and Rails versions they support. This will presumably only be run on new projects so maintaining old versions is unnecessary. Extensions that need to be tested against old versions can use old versions of this gem.
  • Fixed sandbox creation error related to manifest
  • Fixed sandbox error due to not using bundle exec when creating sandbox rails app
  • Fixed: There was an after_suite hook that is erroring because the latest release of https://github.com/solidusio/solidus_paypal_commerce_platform does not have the recent changes made for it to support Rails 8. We're waiting on a new version released if we're going to do that or we can get around it if need be.

TODO:

We're now running up against an issue with how gems are installed on GitHub actions as of Rails 8. We need to update solidus-test-extension to fix this by adding the specified line.
ruby/rubygems#9284 (comment)

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@AlistairNorman AlistairNorman force-pushed the fix-github-actions branch 2 times, most recently from b674894 to 0baee36 Compare February 12, 2026 19:15
@AlistairNorman @Noah-Silvera @sofiabesenski4
Use bundle exec rails in sandbox generation
a60ea28 
Co-Authored-By: Noah Silvera <noah@super.gd>
Co-Authored-By: Sofia Besenski <sofia@super.gd>
@AlistairNorman @Noah-Silvera @sofiabesenski4
Don't use Rails 8 with Solidus 4.4
aa9e790 
These versions aren't compatible.

Co-Authored-By: Noah Silvera <noah@super.gd>
Co-Authored-By: Sofia Besenski <sofia@super.gd>
@jarednorman jarednorman marked this pull request as draft February 12, 2026 19:54
@AlistairNorman AlistairNorman changed the title wip Fix CI Feb 12, 2026
@AlistairNorman AlistairNorman force-pushed the fix-github-actions branch 2 times, most recently from 07359c6 to 9b25ee5 Compare February 12, 2026 22:23
AlistairNorman and others added 3 commits February 12, 2026 14:25
@AlistairNorman @sofiabesenski4
Fix manifest error on sandbox creation
443fc7e 
The sandbox script fails on newer versions of Rails because it expects
the manifest file to exist and contain these links. This matches the
instructions in the ReadMe.

Co-Authored-By: Sofia Besenski <sofia@super.gd>
@AlistairNorman @sofiabesenski4
Add database services
824efd0 
Postgres and mysql are not set up properly by default so we need to add
these to make sure it has the proper setup.

Co-Authored-By: Sofia Besenski <sofia@super.gd>
@AlistairNorman
Avoid problematic versions of state_machines
fa48926 
Due to an issue with state machines, we get a stack level too deep error
when using newer versions of state machines.
@sofiabesenski4 sofiabesenski4 force-pushed the fix-github-actions branch 6 times, most recently from f0ad471 to 2a1ff3a Compare February 19, 2026 22:58
@AlistairNorman AlistairNorman force-pushed the fix-github-actions branch 11 times, most recently from 239e4af to 74d1a06 Compare March 6, 2026 18:19
@AlistairNorman AlistairNorman force-pushed the fix-github-actions branch 4 times, most recently from eb08837 to 5531034 Compare March 6, 2026 19:10
@AlistairNorman
Default to Rails 8
e767091 
We can assume that people using starter frontend will be on newer
versions of Rails because this is only run on new projects.
@AlistairNorman
Fix css compressor issue
ac51c60 
There is an error caused by Sass trying to compile tailwind CSS.
@AlistairNorman AlistairNorman force-pushed the fix-github-actions branch 8 times, most recently from af4a32f to 3e23bcd Compare March 7, 2026 00:06
@AlistairNorman
Specify database url in sandbox script
d0898cb 
The dropping the database was erroring previously.
@AlistairNorman AlistairNorman force-pushed the fix-github-actions branch 3 times, most recently from addeb88 to d0898cb Compare March 7, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlistairNorman