refactor(SFT-2766): Performance issues when using many Conditional Email Notifications#2523
Merged
Conversation
…onditions * tightening rule lookup * optimizing event dispatching for registering form types
refactor: Use Memo cache in `getAllIntegrationTypes` refactor: Use Memo cache in `getAllServiceProviders` refactor: Use Memo cache for integration lookup methods
…fix/SFT-2766-event-cleanup
kjmartens
requested changes
May 18, 2026
Contributor
kjmartens
left a comment
kjmartens
left a comment
There was a problem hiding this comment.
See Jira issue for details
…fix/SFT-2766-event-cleanup
…fix/SFT-2766-event-cleanup
kjmartens
requested changes
May 21, 2026
Contributor
kjmartens
left a comment
kjmartens
left a comment
There was a problem hiding this comment.
Found another issue... when loading the form builder, existing Conditional Rules (Rules tab) do not appear, and this error is in the Network Response:
Solspace\\Freeform\\Records\\Rules\\RuleConditionRecord has no relation named \"form\".
kjmartens
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding memoization, and memoizing as much as possible to reduce redundant object hydration and database calls.