fix: security and process hardening (#732 #733 #734 #735)#753
Open
miracle605 wants to merge 1 commit into
Open
fix: security and process hardening (#732 #733 #734 #735)#753miracle605 wants to merge 1 commit into
miracle605 wants to merge 1 commit into
Conversation
…-plug#733 solutions-plug#734 solutions-plug#735 solutions-plug#732 — services/api/.env.example: replace placeholder values that resembled real secrets with clearly empty or generic equivalents. DATABASE_URL now uses an angle-bracket template; SENDGRID_API_KEY is blank; FROM_EMAIL uses example.com. solutions-plug#733 — .gitleaks.toml: tighten the allowlist. Removed overly broad path globs (all .md files, all test files) that could suppress real leaks. Each remaining entry now has a justification comment and is scoped to the exact file or the narrowest regex that covers the known false positive. solutions-plug#734 — CONTRIBUTING.md: document branch protection rules for main (PR required, CI must pass, 1+ approval, no force push, no deletion) and the development workflow. solutions-plug#735 — .github/CODEOWNERS: created file mapping sensitive paths to designated reviewer teams. contracts/ → smart-contract-team, services/api/src/security.rs → security-team, .github/workflows/ and infrastructure/ → devops. Closes solutions-plug#732 Closes solutions-plug#733 Closes solutions-plug#734 Closes solutions-plug#735
|
@miracle605 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves four related security and process issues in a single batch.
#732 — Clean up
.env.exampleplaceholder valuesservices/api/.env.examplecontained values that resembled real secrets (SG.your_sendgrid_api_key_here,postgres://postgres:postgres@...). These have been replaced with clearly empty or generic equivalents so developers cannot accidentally copy them into production.Changes:
SENDGRID_API_KEY→ blank (empty value)FROM_EMAIL→noreply@example.comDATABASE_URL→ angle-bracket templatepostgres://<user>:<password>@<host>/<dbname>#733 — Tighten
.gitleaks.tomlallowlistThe previous allowlist used broad path globs (
^.*\.md$,^.*test.*\.rs$) that could suppress detection of real secrets committed inside any Markdown or test file. Each entry is now scoped as narrowly as possible and annotated with a justification comment.Changes:
.mdand test-file path allowances.env.examplefiles#734 — Create
CONTRIBUTING.mdwith branch protection rulesNo documentation existed for how
mainis protected or how contributors should work.CONTRIBUTING.mdnow covers:#735 — Create
.github/CODEOWNERSChanges to sensitive paths now automatically request review from the appropriate team.
/contracts/@solutions-plug/smart-contract-team/services/api/src/security.rs@solutions-plug/security-team/.github/workflows/@solutions-plug/devops/infrastructure/@solutions-plug/devops*(default)@solutions-plug/maintainersCloses #732
Closes #733
Closes #734
Closes #735