fix(dx): resolve issues #736, #737, #738, #739 — templates, script, SQL tracking#754
Open
psamist001 wants to merge 1 commit into
Open
fix(dx): resolve issues #736, #737, #738, #739 — templates, script, SQL tracking#754psamist001 wants to merge 1 commit into
psamist001 wants to merge 1 commit into
Conversation
…ions-plug#738, solutions-plug#739 solutions-plug#738 — push_and_create_pr.sh: dynamic repo detection - Derive repository name from `git remote get-url origin` instead of hardcoding it, so the script works after forks or renames. - Validate that `gh` CLI is installed and authenticated before running; exit with a clear error message if either check fails. - Add `--help` flag that prints usage and exits cleanly. solutions-plug#736 — Add .github/pull_request_template.md - Template includes: description, type-of-change checklist, testing done, review checklist (tests pass, docs updated, breaking changes noted), and an issue-reference field (Closes #). solutions-plug#737 — Add .github/ISSUE_TEMPLATE/ with two templates - bug_report.md: steps to reproduce, expected vs actual behaviour, environment details. - feature_request.md: problem statement, proposed solution, alternatives considered. solutions-plug#739 — Track sql/ files in the migration system and document them - Promote performance_indexes.sql into a proper migration: 012_add_performance_indexes.sql (composite indexes on markets and content). - Update DATABASE.md: add sql/ directory section clarifying that the files are query templates / historical drafts, not to be applied manually, and that all schema changes must go through numbered migrations. Closes solutions-plug#736 Closes solutions-plug#737 Closes solutions-plug#738 Closes solutions-plug#739
|
@psamist001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves four DX/reliability issues in a single PR.
#738 —
push_and_create_pr.sh: dynamic repo detectiongit remote get-url origin— no more hardcoded org/repo string that breaks on forks or renames.ghCLI is installed and authenticated before doing any work; exits with a clear, actionable error if either check fails.--helpflag added; prints usage and exits cleanly.#736 — PR template
.github/pull_request_template.md.Closes #issue-reference field.#737 — Issue templates
.github/ISSUE_TEMPLATE/bug_report.md: steps to reproduce, expected vs actual behaviour, environment..github/ISSUE_TEMPLATE/feature_request.md: problem statement, proposed solution, alternatives considered.#739 — Raw SQL files tracked by migration system
sql/performance_indexes.sqlpromoted intodatabase/migrations/012_add_performance_indexes.sql(composite indexes onmarketsandcontent).DATABASE.mdupdated with a new sql/ Directory section that documents both files, marksnewsletter_schema.sqlas superseded by migration 002, and states the rule: no schema-altering SQL may be applied fromsql/directly.Type of Change
Testing Done
push_and_create_pr.sh --helpverified locally.gh auth statusand missing-gherror paths verified manually.Checklist
Related Issues
Closes #736
Closes #737
Closes #738
Closes #739