If the zfs command failed then the command hung. by calling maniwg.Do…#467
Open
recunius wants to merge 1 commit intosomeone1:masterfrom
Open
If the zfs command failed then the command hung. by calling maniwg.Do…#467recunius wants to merge 1 commit intosomeone1:masterfrom
recunius wants to merge 1 commit intosomeone1:masterfrom
Conversation
…ne() in this case the program can exit. No improper side effects noticed, at least for the error, "Error waiting for zfs command to finish - exit status 1: WARNING: could not send X incremental source Y is not earlier than it"
jdfalk
added a commit
to jdfalk/zfsbackup-go
that referenced
this pull request
Nov 13, 2022
Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com>
someone1
requested changes
Feb 13, 2023
Owner
someone1
left a comment
someone1
left a comment
There was a problem hiding this comment.
I appreciate your contribution though have some concerns about the proposed fix!
| case fileBuffer <- true: | ||
| } | ||
| case <-ctx.Done(): | ||
| log.AppLogger.Debugf("manifest copy: ctx.Done(): err = %v", ctx.Err()) |
Owner
There was a problem hiding this comment.
concern: I'm not sure this is the correct spot for this - line 287 should trigger above should any error raise from the underlying zfs backup stream, perhaps actually we should add this to line 300 while waiting to pass along the volume?
Also looking through here, line 358 may also warrant a call to maniwg.Done()...
Perhaps a larger issue here is all the corner cases this method of sync'ing between goroutines has and addressing the TODO below on line 385.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ne() in this case the program can exit.
No improper side effects noticed, at least for the error, "Error waiting for zfs command to finish - exit status 1: WARNING: could not send X incremental source Y is not earlier than it"
This fixes issue #466 at least for this specific ZFS error that I encountered.