fix/pr-965-merge: USDC SEP-41 token interface#994
Merged
Conversation
- Add token_address() helper to resolve XLM/USDC contract address from instance storage based on AssetType enum, using token::Client::new() for all fund movements (deposit, release, partial release, expire, refund, resolve_dispute) - Fix expire() calling transfer_from_contract() without asset_type arg - Store USDC and XLM contract addresses in DataKey::UsdcToken / DataKey::XlmToken during __constructor; validated at init time - Contract is fully parameterised with USDC contract ID — no hardcoded addresses anywhere in the escrow logic - Fix test tuple destructuring: setup_env() returns 8-tuple (added xlm); update all test sites that were missing the _xlm binding - Add AssetType::Usdc argument to deposit() calls in tests that were missing it (boundary tests, KYC gating tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #806