Skip to content

[Mellanox] Add phcsync warm reboot gate to avoid sync during warm reboot#26332

Closed
zili11720 wants to merge 6 commits into
sonic-net:masterfrom
zili11720:avoid_clock_sync_during_warm_reboot
Closed

[Mellanox] Add phcsync warm reboot gate to avoid sync during warm reboot#26332
zili11720 wants to merge 6 commits into
sonic-net:masterfrom
zili11720:avoid_clock_sync_during_warm_reboot

Conversation

@zili11720
Copy link
Copy Markdown
Contributor

@zili11720 zili11720 commented Mar 23, 2026

This PR is related to:
sonic-net/sonic-sairedis#1810
sonic-net/sonic-swss-common#1161

Together, these PRs introduce an event-driven mechanism that starts and stops phcsync.sh during a warm reboot.

Order of merge:

  1. [Warm Restart] Add waitWarmBootStarted to restartWaiter sonic-swss-common#1161
  2. [Mellanox] Add phcsync warm reboot gate to avoid sync during warm reboot #26332
  3. [Mellanox] Activate phcsync gate to prevent clock sync during warm reboot sonic-sairedis#1810

Why I did it

This fixes an issue where clock synchronization accessed the ASIC clock concurrently with the warm reboot ISSU process.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add phcsync_warm_reboot_gate.py to start/stop phcsync.sh during warm reboot.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Signed-off-by: Zili Bombach <zbombach@nvidia.com>
@zili11720 zili11720 requested a review from lguohan as a code owner March 23, 2026 13:42
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@zili11720 zili11720 marked this pull request as draft March 23, 2026 17:01
@zili11720 zili11720 marked this pull request as ready for review March 23, 2026 17:02
@yijingyan2
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants