[test] Build with ComponentStats-based SwssStats (PR sonic-swss#4516 + sonic-swss-common#1180)#27456
Conversation
…+ sonic-swss-common#1180) Recreated on top of current master to resolve conflicts in sonic-net#26924. Repoints submodules to forks carrying the ComponentStats refactor: - src/sonic-swss-common -> yutongzhang-microsoft @ feature/component-stats (55673525d58) - src/sonic-swss -> yutongzhang-microsoft @ swss-stats-use-componentstats (37100258229) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
yutongzhang-microsoft
force-pushed
the
swss-stats-implementation-v2
branch
from
23818d2 to
8d6f951
Compare
|
/azpw run |
3 similar comments
|
/azpw run |
|
/azpw run |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
No Azure DevOps builds found for #27456. |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
No Azure DevOps builds found for #27456. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
No failed(or canceled) stages or jobs found in the most recent build 1118130. |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
No failed(or canceled) stages or jobs found in the most recent build 1118130. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
@copilot resolve the merge conflicts in this pull request |
…+ sonic-swss-common#1180) Recreated on top of fresh upstream master to drop the conflicts from sonic-net#27456. Repoints two submodules to forks carrying the refactored library + thin-wrapper: | submodule | now | source PR | |---|---|---| | src/sonic-swss-common | b21b74e (feature/component-stats) | sonic-net/sonic-swss-common#1180 | | src/sonic-swss | 3710025 (swss-stats-use-componentstats) | sonic-net/sonic-swss#4516 | .gitmodules URLs are temporarily switched to https://github.com/yutongzhang-microsoft/... so CI can resolve the non-upstream SHAs. The swss-common SHA already includes banidoru's review fixes (lock-free hot path via shared_mutex + merged lookupOrCreate, final flush on shutdown, registry pruning, setValue exclusive lock + docs). Supersedes sonic-net#27456. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Superseded by #27554 — recreated on top of fresh upstream master to drop the conflicts that had accumulated here. New PR also bumps swss-common to b21b74e which includes banidoru's review fixes from sonic-net/sonic-swss-common#1180. |
…review fixes) Picks up review fixes from sonic-net/sonic-swss-common#1180 that address banidoru's feedback: * Lock-free hot path via shared_mutex + merged lookupOrCreate * Final flush on shutdown so no in-flight updates are dropped * Registry pruning of expired weak_ptr slots * setValue exclusive lock + documented gauge/counter mixing caveat Public API (increment/setValue/get/getAll/setEnabled/stop) is unchanged, so sonic-swss SwssStats facade does not need to move. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3 participants
Do not merge — recreated on top of current master to resolve the conflicts in #26924.
Repoints both submodules to forks carrying the refactored library + thin-wrapper:
feature/component-stats)swss-stats-use-componentstats).gitmodulesURLs are temporarily switched tohttps://github.com/yutongzhang-microsoft/...so CI can resolve the non-upstream SHAs.Supersedes #26924.
How to verify
SET / DEL / COMPLETE / ERRORcounters incrementing as orchagent processes tasks.Follow-up
Once both source PRs are merged upstream, this PR will be rewritten to:
.gitmodulesURLs tosonic-net/...