[dhcp_device]: Tolerate multiple IPv6 link-local addresses on interface#79
Open
Bojun-Feng wants to merge 2 commits into
Open
[dhcp_device]: Tolerate multiple IPv6 link-local addresses on interface#79Bojun-Feng wants to merge 2 commits into
Bojun-Feng wants to merge 2 commits into
Conversation
* Allow interfaces with more than one LLA to pass initialization * Store only the first discovered LLA for packet identification Signed-off-by: Bojun-Feng <bojundf@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix sonic-net/sonic-buildimage#27586
After #62, dhcpmon exits during startup when the management interface has more than one IPv6 link-local address. This is a valid Linux networking configuration (e.g., both a kernel EUI-64 LLA and a statically configured management LLA coexist on eth0). The strict equality check causes dhcpmon to treat this as fatal, breaking DHCP relay health monitoring and blocking sonic-mgmt dhcpv4 relay tests.
How I did it
How to verify it
ip -6 addr add fe80::dead:beef:1/64 dev eth0 scope linkdocker exec dhcp_relay supervisorctl status dhcpmon-Vlan1000Description for the changelog
Fixed dhcpmon crash on interfaces with multiple IPv6 link-local addresses by tolerating any number of LLAs and using the first one found.