Add noaer_recovery and nodpc pci kernel boot option#583
Open
yurypm wants to merge 2 commits into
Open
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
What is the upstreaming plan for these patches? |
AER error recovery is part of the AER error handling subsystem in the Linux kernel. AER is enabled by default in the SONiC Linux kernel. The default Linux behavior is incompatible with Arista chassis hardware architecture. Enabling AER recovery on large modular systems with a complex PCIe tree could cause unexpected behavior and side effects. It would be nice to have an option to disable AER recovery on some chassis. Add pci=noaer_recovery kernel boot option to disable AER error recovery when an uncorrectable error is reported. Signed-off-by: Yury Murashka <yurypm@arista.com>
PCI DPC (Downstream Port Containment) is enabled by default in the SONiC Linux kernel. DPC support can be advertised by PCIe devices, but it might not be fully supported in the firmware. The default Linux behavior is incompatible with Arista chassis hardware architecture. Enabling DPC could cause unexpected behavior and side effects. It would be nice to have an option to disable DPC on some chassis. Add pci=nodpc kernel boot option to disable PCI DPC. Signed-off-by: Yury Murashka <yurypm@arista.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
I don't think that there is any chance that these patches will be accepted into upstream. |
Contributor
Please send them to be sure. They are already properly formatted, so please send them upstream. |
Contributor
Author
Done. https://lore.kernel.org/linux-pci/20260602105558.1799563-1-yurypm@arista.com/T/#t |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCI DPC (Downstream Port Containment) is enabled by default in the SONiC Linux kernel. DPC support can be advertised by PCIe devices, but it might not be fully supported in the firmware. The default Linux behavior is incompatible with the Arista chassis hardware architecture. Enabling DPC could cause unexpected behavior and side effects.
It would be nice to have an option to disable DPC on some chassis.
AER error recovery is part of the AER error handling subsystem in the Linux kernel. AER is enabled by default in the SONiC Linux kernel. The default Linux behavior is incompatible with the Arista chassis hardware architecture. Enabling AER recovery on large modular systems with a complex PCIe tree could cause unexpected behavior and side effects.
It would be nice to have an option to disable AER recovery on some chassis.
Add pci=noaer_recovery kernel boot option to disable AER error recovery when an uncorrectable error is reported.
Add pci=nodpc kernel boot option to disable PCI DPC.