add cpo bailly xcvr cmis#672
Merged
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
micas-net
reviewed
May 22, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
Collaborator
|
/azp run |
1 similar comment
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@KroosMicas pls fix the DCO error. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Jun 1, 2026
Collaborator
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
@KroosMicas are we aligned to the latest design?
Contributor
Author
Yes, for memmap, we have implemented it using the latest single-page approach. And it has been fully verified through the latest optical driver. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Bailly CPO (ELS) support to sonic_platform_common’s transceiver framework by introducing Bailly-specific CMIS extensions (codes, fields, memory map, and API) plus a new CPO Optoe base class and unit tests.
Changes:
- Add Bailly-specific CMIS extensions: codes (
BaillyCodes), fields/constants (bailly_consts), and memory map (BaillyMemMap). - Add Bailly-specific API (
BaillyApi) that extends CMIS behavior and augmentsget_transceiver_info(). - Add a new
CpoOptoeBasehelper and unit tests for the new Bailly components; update packaging list insetup.py.
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/sonic_xcvr/test_bailly_optoe_base.py | New unit tests for CpoOptoeBase JSON/config, EEPROM access, and presence logic |
| tests/sonic_xcvr/test_bailly_cmis.py | New unit tests for BaillyApi/BaillyCodes (includes a broken patch target needing fixes) |
| sonic_platform_base/sonic_xcvr/mem_maps/bailly/bailly_mem_map.py | New Bailly CMIS page definitions (B0/B1/B2) and memory map class |
| sonic_platform_base/sonic_xcvr/mem_maps/bailly/init.py | Package init for Bailly mem maps |
| sonic_platform_base/sonic_xcvr/fields/bailly/bailly_consts.py | New Bailly field name constants used by mem map/API |
| sonic_platform_base/sonic_xcvr/fields/bailly/init.py | Package init for Bailly fields |
| sonic_platform_base/sonic_xcvr/codes/bailly/bailly_codes.py | New Bailly code dictionaries (identifiers, interfaces, laser-related enums) |
| sonic_platform_base/sonic_xcvr/codes/bailly/init.py | Package init for Bailly codes |
| sonic_platform_base/sonic_xcvr/bailly_optoe_base.py | New CPO Optoe base class and cpo.json reader (has several robustness issues) |
| sonic_platform_base/sonic_xcvr/api/bailly/bailly_api.py | New Bailly API extending CMIS and enriching transceiver info |
| sonic_platform_base/sonic_xcvr/api/bailly/init.py | Package init for Bailly API |
| setup.py | Register new Bailly packages for distribution |
prgeor
reviewed
Jun 4, 2026
Collaborator
There was a problem hiding this comment.
@KroosMicas this is NOT aligned with the design. but we should fix this later.
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Kroos <kroos@micasnetworks.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Jun 4, 2026
Collaborator
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
@KroosMicas where is the RLM API and memory map?
Contributor
Author
|
prgeor
approved these changes
Jun 5, 2026
Collaborator
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
@KroosMicas agreed that the code will be re-arranged later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add CPO Bailly-related CMIS APIs/MEM maps/Code/Fields as well as the CPO management base class
Motivation and Context
Run Bailly using the community framework
How Has This Been Tested?
Additional Information (Optional)