Fix mocktests for buster builds#1087
Merged
Merged
Conversation
* PTF build still uses buster which does not support INSTANTIATE_TEST_SUITE_.
This changes fixes the error below
```
tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token
INSTANTIATE_TEST_SUITE_P(
^
tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
)
^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1
```
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vivekrnv
approved these changes
Oct 10, 2025
saiarcot895
approved these changes
Oct 10, 2025
Collaborator
|
Cherry-pick PR to msft-202506: Azure/sonic-swss-common.msft#69 |
jasper-hou-micas
pushed a commit
to jasper-hou-micas/sonic-swss-common
that referenced
this pull request
Jan 22, 2026
* PTF build still uses buster which does not support INSTANTIATE_TEST_SUITE_.
This changes fixes the error below
```
tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token
INSTANTIATE_TEST_SUITE_P(
^
tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
)
^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1
```
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
Collaborator
|
Cherry-pick PR to 202511: #1171 |
Collaborator
|
@prabhataravind cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@prabhataravind cherry pick PR didn't pass PR checker after retry. Please help check! Thanks. ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.