Document ar, tr, vi and id as dubbing targets - #35
Merged
Conversation
The pipeline gained Arabic, Turkish, Vietnamese and Indonesian; this SDK and its CLI kept listing thirteen. Neither validates language codes locally — `languages` travels as an opaque JSON array string that the backend parses — so nothing was rejecting the new codes. What was stale is the list a caller reads: `--languages --help`, both READMEs, and the context7 rule a model reads when it picks languages on the user's behalf. ar is unqualified Arabic rather than one of HeyGen's seventeen country variants, so it is the es/pt shape and not the pt_br one; each doc line says so, because "Arabic" alone invites the assumption that a dialect can be requested. tr, vi and id are plain single-region entries. context7.json's rule needed tightening rather than just extending: four more codes pushed it past the 255-character ceiling that sonilo-cli/tests/test_context7.py enforces. "several" became "many" and "a list of codes (...)" lost its parenthesis, which buys the room without dropping anything the rule exists to convey. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lightsage docs evalsWaiting for the staging docs URL before running evals. Lightsage will start the selected PR evals automatically when GitHub reports a successful docs deployment for this PR. This usually happens within 15 minutes. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dubbing pipeline gained Arabic, Turkish, Vietnamese and Indonesian. The SDK and CLI kept listing thirteen codes.
Neither validates language codes locally —
languagestravels as an opaque JSON array string that the backend parses — so nothing here was rejecting the new languages. What was stale is the list a caller reads.Changes
sonilo-cli/src/sonilo_cli/__main__.py—--languageshelp textREADME.md,sonilo-cli/README.md— docscontext7.json— the rule a model reads when picking languagesNotes
aris unqualified Arabic, not one of HeyGen's seventeen country variants — thees/ptshape rather than thept_brone. Each doc line says so explicitly, since "Arabic" alone invites the assumption that a dialect can be requested.context7.json's dubbing rule had to be tightened, not just extended: four more codes pushed it past the 255-character ceiling thatsonilo-cli/tests/test_context7.pyenforces. "several" → "many" and dropping the parenthesis around the code list buys the room without losing anything the rule exists to convey.Verification
289 SDK tests and 154 CLI tests pass (run in a clean venv — the ambient environment is missing
respx, which is unrelated to this change).🤖 Generated with Claude Code