Skip to content

Adding glow pulse visualization - #392

Draft
phayes wants to merge 11 commits into
sonorahq:devfrom
phayes:main
Draft

phayes wants to merge 11 commits into
sonorahq:devfrom
phayes:main

Conversation

@phayes

@phayes phayes commented Sep 3, 2026

Copy link
Copy Markdown

Please find first-cut of glow pulse visualization on the album art on the player.

Changes to existing code:

  1. Spectrum now reads from before volume instead of after, so volume changes don't affect visualization.
  2. Spectrum was improved to add a few more common things needed by visualizers instead of just frequency bands. I added lows, mids, and highs, as well as peak and rms.

New code:

Most of the new code is in frame_glow.rs . I think it's a bit overly complex for now for what it does, but I want to get feedback on the visual effect before stripping it down to basics (I originally tried for a more complex visualization than I ended up using, and much of that original machinery is still in place).

What I would like feedback on:

  1. Overall impressions of the glow
  2. Is the glow too-big or too bright?
  3. How's the colour? Do we want to colour-match it to the album better?

Once I get this feedback I'll tweak it and simplify the code a bit.

@nolight132
nolight132 changed the base branch from main to dev September 3, 2026 22:00
@nolight132
nolight132 marked this pull request as draft September 3, 2026 23:07
@sonora-buddy sonora-buddy Bot added playback audio output, stutter, gaps, seeking, volume, the equalizer views labels Sep 14, 2026
@nolight132 nolight132 removed the views label Sep 14, 2026
@sonora-buddy sonora-buddy Bot added lyrics lyric fetching, timing, the lyrics view, any lyrics provider player the player bar, the queue, transport, fullscreen, media keys labels Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lyrics lyric fetching, timing, the lyrics view, any lyrics provider medium priority needs triage playback audio output, stutter, gaps, seeking, volume, the equalizer player the player bar, the queue, transport, fullscreen, media keys

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants