Conversation
…bar first, then will revisit fullscreen later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please find first-cut of glow pulse visualization on the album art on the player.
Changes to existing code:
New code:
Most of the new code is in frame_glow.rs . I think it's a bit overly complex for now for what it does, but I want to get feedback on the visual effect before stripping it down to basics (I originally tried for a more complex visualization than I ended up using, and much of that original machinery is still in place).
What I would like feedback on:
Once I get this feedback I'll tweak it and simplify the code a bit.