Skip to content

Use Premium YouTube audio automatically and show a Premium badge - #455

Open
dariusnv wants to merge 1 commit into
sonorahq:devfrom
dariusnv:feat/youtube-premium-pr
Open

dariusnv wants to merge 1 commit into
sonorahq:devfrom
dariusnv:feat/youtube-premium-pr

Conversation

@dariusnv

@dariusnv dariusnv commented Sep 5, 2026

Copy link
Copy Markdown

Summary

  • automatically request the signed-in account's highest-bitrate audio-only stream, including Premium AAC and Opus, so subscribers use the quality included in their subscription without another setting
  • fall back to ordinary audio if authenticated resolution or downloading fails; keep guest playback unchanged
  • enable WebM audio decoding for YouTube Opus streams and record the selected codec and reported bitrate at debug level; download no video
  • show a small Premium badge beside YouTube Music in Settings → General after the session confirms High-tier audio; clear confirmation on account/session changes and make no extra membership requests
  • use ytmusic-rs #5, currently pinned to the tested fork commit; update the dependency to its upstream revision once that companion PR merges
  • verify 279 tests, formatting and clean Clippy on the current upstream Sonora base, plus 36 tests in the companion library; live Windows checks cover Premium AAC/Opus download, decoding and seeking, invalid-authentication fallback to ordinary AAC, and the badge's placement in the built app
  • keep this separate from Add Discord Rich Presence, YouTube account photos, and audio math fixes #443; note that the badge confirms Premium audio availability after a track is resolved, rather than querying billing status, and macOS/Linux runtime behavior was not manually tested

@imizgun imizgun added enhancement New feature or request good first issue Good for newcomers needs triage labels Sep 5, 2026
@sonora-buddy sonora-buddy Bot added documentation Improvements or additions to documentation i18n translations, missing strings, plurals, locale selection views youtube the YouTube Music backend, its library, search and sign-in labels Sep 14, 2026
@nolight132 nolight132 removed the views label Sep 14, 2026
@sonora-buddy sonora-buddy Bot added settings the settings screen, stored preferences, the updater and removed i18n translations, missing strings, plurals, locale selection labels Sep 14, 2026
@nolight132 nolight132 removed the good first issue Good for newcomers label Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request needs triage settings the settings screen, stored preferences, the updater youtube the YouTube Music backend, its library, search and sign-in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants