feat(music): add youtube captions as a lyrics fallback - #466
Open
ArthurAugis wants to merge 2 commits into
Open
ArthurAugis wants to merge 2 commits into
ArthurAugis wants to merge 2 commits into
Conversation
- add a youtube captions lyrics provider, timed line by line from the video's own subtitle track - prefer the caption track in the app's language, then the spoken one, then any authored one - add a \ allback\ flag to lyrics hits so captions are dropped whenever a real lyrics source answers - keep a track marked instrumental instrumental, rather than standing in with its dialogue captions - carry the active language on the lyrics query so a language change is followed - add a captions prober example and teach the lyrics prober the new provider
- integrate the upstream release: the storage crate, per-provider credentials, Home Manager module - keep both the captions and credentials module declarations in music - keep the captions entry under Unreleased, above the 0.31.0 section
sonora-buddy
Bot
added
lyrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary