Skip to content

feat(local): load same-name lrc files - #475

Closed
SharnavM wants to merge 1 commit into
sonorahq:devfrom
SharnavM:feat/local-lrc
Closed

SharnavM wants to merge 1 commit into
sonorahq:devfrom
SharnavM:feat/local-lrc

Conversation

@SharnavM

@SharnavM SharnavM commented Sep 6, 2026

Copy link
Copy Markdown

Adds support for loading local .lrc files for music if they exist.

  • Local .lrc files take priority over internet lyrics.
  • Internet lyrics are used as a fallback if the .lrc file doesn't exist or is empty, only if the internet privacy setting is on.
  • Changed the label for the lyrics privacy option to match the new behavior.
  • The build compiles successfully for all supported platforms. Manual testing has been completed on Windows; manual testing on macOS and Linux remains.

Partially addresses #398.

@imizgun imizgun self-assigned this Sep 6, 2026
@imizgun imizgun added enhancement New feature or request medium priority labels Sep 6, 2026
@sonora-buddy sonora-buddy Bot added i18n translations, missing strings, plurals, locale selection local the local music folder, scanning, tags, artwork, local playlists state labels Sep 14, 2026
@nolight132 nolight132 removed the state label Sep 14, 2026
@sonora-buddy sonora-buddy Bot added lyrics lyric fetching, timing, the lyrics view, any lyrics provider and removed i18n translations, missing strings, plurals, locale selection labels Sep 14, 2026
@imizgun

imizgun commented Sep 20, 2026

Copy link
Copy Markdown
Member

Hello, Sharnav. Thank you for your contribution.
We decided to keep implementing a feature started by you from PR #632, since it was more lived up to the current branch state.
Anyway, thank you for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request local the local music folder, scanning, tags, artwork, local playlists lyrics lyric fetching, timing, the lyrics view, any lyrics provider medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants