Skip to content

fix(settings): hand focus back to the page when a picker closes - #601

Merged
nolight132 merged 1 commit into
sonorahq:devfrom
fengqiu233:fix-fullscreen
Sep 20, 2026
Merged

nolight132 merged 1 commit into
sonorahq:devfrom
fengqiu233:fix-fullscreen

Conversation

@fengqiu233

@fengqiu233 fengqiu233 commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • give the language and typeface pickers the settings page focus handle back when they close, so an action raised by a later click still finds a dispatch path
  • take that handle in SearchPopup::new rather than through a setter, so no caller can forget it

Closes #584

@fengqiu233

Copy link
Copy Markdown
Contributor Author

Hi, I found a new bug. It's still the same issue:

  • In the first step, switching the language doesn't actually switch it.

  • After clicking Search and other areas outside, the fullscreen button doesn't respond.

  • The fullscreen button only responds after I click another area.

So far, I have only fixed the issue where selecting from the menu bar and then clicking the fullscreen button allows me to enter fullscreen mode.:(

Asking you to fix the bug.

@sonora-buddy sonora-buddy Bot added ui rendering, layout, theming, icons, fonts, the window itself views labels Sep 14, 2026
@nolight132 nolight132 removed the views label Sep 14, 2026
@sonora-buddy sonora-buddy Bot added settings the settings screen, stored preferences, the updater documentation Improvements or additions to documentation playback audio output, stutter, gaps, seeking, volume, the equalizer spotify the Spotify backend, its library, search and sign-in youtube the YouTube Music backend, its library, search and sign-in subsonic a Subsonic or Navidrome server local the local music folder, scanning, tags, artwork, local playlists lyrics lyric fetching, timing, the lyrics view, any lyrics provider icons the icon packs webview the cookie sign-in browser window nix the flake, the devShell, building under Nix ci the release workflow and everything else under .github player the player bar, the queue, transport, fullscreen, media keys library playlists, albums, artists, history, pins and the browsing screens search the search field and what it returns and removed documentation Improvements or additions to documentation playback audio output, stutter, gaps, seeking, volume, the equalizer spotify the Spotify backend, its library, search and sign-in youtube the YouTube Music backend, its library, search and sign-in subsonic a Subsonic or Navidrome server local the local music folder, scanning, tags, artwork, local playlists lyrics lyric fetching, timing, the lyrics view, any lyrics provider icons the icon packs webview the cookie sign-in browser window nix the flake, the devShell, building under Nix ci the release workflow and everything else under .github labels Sep 14, 2026
@sonora-buddy sonora-buddy Bot removed player the player bar, the queue, transport, fullscreen, media keys library playlists, albums, artists, history, pins and the browsing screens search the search field and what it returns labels Sep 15, 2026
@fengqiu233 fengqiu233 changed the title fix(views/ui):fix views/screens/setting and ui/menu fix(settings): return focus to the settings view on picker close Sep 15, 2026
@fengqiu233

Copy link
Copy Markdown
Contributor Author

It's already fixed, please merge it

Fixes: #584

@sonora-buddy sonora-buddy Bot removed the ui rendering, layout, theming, icons, fonts, the window itself label Sep 20, 2026
@nolight132 nolight132 changed the title fix(settings): return focus to the settings view on picker close fix(settings): hand focus back to the page when a picker closes Sep 20, 2026
@nolight132
nolight132 merged commit 077425e into sonorahq:dev Sep 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

settings the settings screen, stored preferences, the updater

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants