Improved symbol handling #1942
Open
Improved symbol handling #1942
+68
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
If I get this right, you "just" replaced the locking structure, right ? The previous iteration was adding an extra cache, but this PR does not, correct ? |
Author
Yes. We did have a PR for symbol cache which we are still looking into. But this is about locking and the string interning micro optimisation. |
Collaborator
|
Pleasse make sure clippy is happy, and we'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on benchmarks the following performance improvements:
LinearClassifier / 100,000 - 94.7%
LinearClassifier / 1,000,000 - 13.7%
LinearRegressor / 100,000 - 48.3%
LinearRegressor / 1,000,000 - 7.07%