Repository navigation
Add Chrome and Brave support and save open tabs - #1
Merged
Merged
Conversation
Generate a shared Chromium Manifest V3 build with a module service worker while preserving the default Firefox build and signing workflow. Use the cross-browser contextMenus API and add a browser namespace fallback for Chromium versions before 148. Select writable bookmark folders using browser metadata, omit root and managed folders from folder choices, and avoid rebuilding persistent menus on every background-worker start. Document unpacked installation for Chrome and Brave and add regression coverage for manifests, API initialization, and Chromium bookmark trees. Synchronize package, lockfile, and manifest versions at 1.1.0. Validation: 32 tests pass; Firefox and Chromium builds pass. Chrome 155 and Brave Chromium 145 smoke checks cover extension loading, settings persistence, menu handlers, and popup loading.
Route right-click saves through the shared serialized save flow and compare normalized URLs in the final folder, including date subfolders. Allow the same link in other collections and preserve existing metadata on skips. Keep meaningful query parameters, fragments, and path differences while ignoring known tracking parameters on both saved and incoming URLs. Add batch saving with one lookup per destination and individual failure results. Update duplicate-setting copy and add regressions for concurrency, metadata preservation, folder scope, URL comparison, and right-click integration. Validation: 38 tests pass; Firefox and Chromium builds pass. A real Chrome bookmark check confirms duplicate skipping and metadata preservation.
Add a popup flow to save web tabs from the current window in tab order, with an existing-folder picker and optional new subfolder. Keep source tabs open and show saved, skipped, and failed counts. Route batches through the background worker and shared serialized save logic, respecting the duplicate setting and recording dashboard metadata. Use the selected folder directly without automatic date subfolders, and select newly created folders for safe retries. Skip unsupported URLs, validate destinations and folder names, document the feature, and keep four focused regression tests. Reduce the quote divider to a subtle 1px border. Validation: 42 tests pass; Firefox and Chromium builds pass. Chrome and Brave UI checks cover new-folder creation, tab order, dashboard records, repeat-save deduplication, and leaving tabs open. The user confirmed the feature works in Firefox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BagMark now runs in Firefox, Chrome, and Brave, and can save all web tabs from the current window into an existing folder or a new subfolder. Tabs stay open, tab order is preserved, and the popup reports saved, skipped, and failed counts.
Duplicate prevention compares both URLs in the final destination folder, allowing the same link in other collections and preserving existing metadata when skipping a duplicate. Right-click and batch saves share a serialized background save flow. URL comparison ignores known tracking parameters while retaining meaningful query parameters, fragments, and path differences.
The Chromium build uses a Manifest V3 service worker and a namespace fallback for older Chromium versions. Firefox remains the default build. Version is bumped to 1.1.0, installation instructions are updated, and PR CI runs the existing tests plus both browser builds.
Validation: