Rename rfmt to kenshin - #123
Closed
sorafujitani wants to merge 5 commits into
Closed
Conversation
Owner
Author
|
Decision: keeping the name rfmt (codename v2). Closing unmerged. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the project rfmt → kenshin, per the plan in #110 ("Rename: rfmt → kenshin" section). The name is verified free on RubyGems, and
sorafujitani/kenshinis unused on GitHub.What changes
kenshin(version stays 1.7.0; the bump happens at release). Executableskenshin/kenshin-lsp.Kenshin, withRfmt = Kenshinkept as a deprecation alias for one minor release.ext/kenshin(crate/lib name drives the magnus init symbol;require 'kenshin'verified afterrake compile)..kenshin.ymlfamily and still accepts the legacy.rfmt.ymlnames afterward, in both the Rust resolver and the Ruby finders (tested on both sides; transition window noted in code).~/.cache/kenshin. Env varsKENSHIN_DEBUG/LOG/VERBOSE(old names dropped; flagged in the changelog).kenshinexe), CHANGELOG entry describing the rename and migration path.What deliberately keeps the old name
sorafujitani/rfmtuntil the GitHub repo itself is renamed (that is the maintainer's post-merge step; redirects then cover stragglers). The gemspec metadata already points tosorafujitani/kenshin.lib/rfmt/...path andRfmt::reference are historical by nature (verified idempotent: fixtures regenerate byte-identically).grep -rniE "\brfmt\b"inventory over lib/ext/exe/spec/scripts/.github was reviewed hit-by-hit; every remaining hit falls in the categories above.Verification
--all-targets -D warnings/ fmt clean; rubocop cleangem build kenshin.gemspec: name/executables/extensions correct;ruby_lsp_addonmetadata intactbundle exec kenshin --writehonors.kenshin.yml(indent 4) and legacy.rfmt.yml(indent 3) in separate temp projects;--checkexit codes;kenshin versionreports the new nameKenshin.formatand legacyRfmt.formatreturn identical outputAfter merge (maintainer steps)
sorafujitani/kenshin(old URLs redirect)kenshinrelease carries the native-parsing migration + rename changelog; a finalrfmtgem release points users here (post_install_message)