Allow for quantity-string time delta as CxoTime initializer#60
Merged
Allow for quantity-string time delta as CxoTime initializer#60
Conversation
jeanconn
approved these changes
Oct 7, 2025
Contributor
jeanconn
left a comment
There was a problem hiding this comment.
This looks good, though given using DateTime is already unofficially deprecated, I'm not sure if new code will ever exist to use it?
Member
Author
|
This addresses the large swath of older Ska code that uses |
Contributor
|
Good point. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a long-standing desire of mine to allow supplying a delta time offset from now to initialize
DateTime.This is in the form
"+/-1yr 2d 3hr 4.2min 10.25s". Any function or command line tool that uses SkaCxoTimeorDateTimewill work with this format.This is especially convenient for command line arguments like
--start=-14d --stop=-7d, or similar for any function that hasDateTimeLikestart/stopargs.This leverages the same functionality in
CxoTime.Requires
Interface impacts
Adds a new way to initialize DateTime.
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.