Conversation
18 tasks
Contributor
Author
|
It looks like there are a few more repr() calls in Time.py, but that they are working on values that have already been explicitly converted to Python floats. So we can update those to str() or not - they look to be non-impacting for numpy 2. |
javierggt
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
repr() was intended to get the number to as many digits as available to pass to convert_time, in modern Python using str() should be fine.
This has no impact in numpy 1.26.4 but is required for this code to work with numpy > 2 as the new repr behavior (includes the np type in the string) doesn't work with axTime3.convert . With Python > 3.1, str() should have enough digits for this code change to be non-impacting.
Interface impacts
None.
Testing
Unit tests
And on the latest hope rc
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.