Support HRC 15V On from SCS-85 activation#384
Conversation
|
@taldcroft pardon me if I should know this already, but how is the transition from previous commands which used SCS-134 to the new SCS-85 commanding handled? I'm thinking about situations like when one sets the "now" CxoTime to some point in the past and we rely on the commanding to create the right states. |
|
We should probably update the description to indicate that the SCS134 code was left alone, so there should not be issues with historical compatibility. Operationally this should be acceptable as there is no plan to reuse SCS134 at this time. |
jeanconn
left a comment
There was a problem hiding this comment.
Looks good to me. Optional comment is to update the description to note that it is back compatible with the previous SCS134 commanding. It would also be nice to add a unit test for the time_delay attribute, but I agree this is straightforward and the functional testing is fine.
|
I updated the description accordingly. Agreed that a unit test might be nice but I'd like to leave that as an action for when there are flight loads that include this commanding. Then it will be quite easy to replicate my functional test in a unit test. Right now it is possible but a bit tedious. |
|
For the MATLAB release, I noted that for SCS85 we are tracking the HRC 15V turn on ( |
|
Good point @jskrist . Ken noted this but as you guessed from your search, kadi wasn't tracking the shield / 2S2ONST state anyway, so that half of the scs85 change is presently not impacting for the kadi commanded states. |
Description
With the release of MATLAB tools 2026_020, load commanding is updated so that the HRC 15V power supply is turned on via activation of SCS-85. Previously this was done via SCS-134.
This PR adds support for setting the
hrc_15vstate toONat a time 22.166 seconds after the SCS-85 activation command. The time delay was provided by K. Gage.To support the time delay, a new
time_delayclass attribute was added to theFixedTransitionclass. The code for this is straightforward.Interface impacts
None.
This is back-compatible with older loads that use SCS-134 since the state-changing class that watches for SCS-134 has not been removed. There are currently no plans to repurpose SCS-134 since that SCS is quite small. If that did happen it would be possible to have the state transition depend on the date of the command.
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
The following script (run in this repo directory) provides the following output.
Script
Output
The SCS-85 activation times are listed below:
2026:048:18:51:11.0272026:049:13:09:34.924The
hrc_15vONtimes are 22 seconds afterward.I also confirmed that without this patch, the states show
hrc_15vin theOFFstate for the entire load.