Skip to content

Support HRC 15V On from SCS-85 activation based on 7.19.0 #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javierggt wants to merge 2 commits into from
Closed

Support HRC 15V On from SCS-85 activation based on 7.19.0 #385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee91d25
Add support for time_delta in FixedTransition
taldcroft Mar 31, 2026
40211b8
Support HRC 15V state "on" from SCS-85 activation
taldcroft Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion kadi/commands/states.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,10 @@ class FixedTransition(BaseTransition):
:param transition_val: single transition value or list of values
"""

# If specified set the time delta for actual transition relative to command time.
# This should be an astropy time Quantity like 10 * u.s.
time_delta = None

@classmethod
def set_transitions(cls, transitions_list: list[Transition], cmds, start, stop):
"""
Expand Down Expand Up @@ -478,7 +482,10 @@ def set_transitions(cls, transitions_list: list[Transition], cmds, start, stop):
attrs = [attrs]

for cmd in state_cmds:
transitions_list.append(Transition(cmd["date"], zip(attrs, vals))) # noqa: PERF401
date = cmd["date"]
if cls.time_delta is not None:
date = (CxoTime(date) + cls.time_delta).date
transitions_list.append(Transition(date, zip(attrs, vals))) # noqa: PERF401


class ParamTransition(BaseTransition):
Expand Down Expand Up @@ -796,6 +803,23 @@ class Hrc15vOn_SCS134_Transition(FixedTransition):
default_value = "ON"


class Hrc15vOn_SCS85_Transition(FixedTransition):
"""HRC 15V ON from SCS-85

This is the default in operations following release of MATLAB 2026_020
and supercedes commanding of SCS-134.
"""

command_attributes = {"tlmsid": "COACTSX", "coacts1": 85}
state_keys = ["hrc_15v"]
transition_key = "hrc_15v"
transition_val = "ON"
default_value = "ON"
# Actual 15V on is 22.166 s after SCS-85 activation. Source: K. Gage communication
# 2026-03-31.
time_delta = 22.166 * u.s


class Hrc15vOff_Transition(FixedTransition):
"""HRC 15V OFF"""

Expand Down
Loading