Further improvements to kadi observations#387
Merged
Conversation
Do this in ruff-base to match expected change in skare3
2 tasks
jeanconn
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes a number of improvements to the kadi observations code for both users and developers.
User
get_observationto get a single observation.Nonevalue for obs_filter be a pass-thru instead of matchingNone.Developer
Interface impacts
Adds a new function
get_observation()that raises an exception unless exactly on matching observation is found.Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.