Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for new tcsh_shell that has default behavior of check=True which raises exception on nonzero cmd exit status.
The pipe commands look to always have status=80 if an "-S pipe" is supplied, so this just handles that conditionally for our common use cases.
While in there there were a couple of trivial fixes hanging out in my local copy (adding another pipe to the list, handling the case where stop_pipe == check_star_data) and I updated to use the non-namespace versions of the ska packages for easier testing.
Requires sot/ska_shell#31