Add an "unbuffered" argument to shell functions#33
Open
Conversation
…put to be logged as it arrives instead of all at the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an "unbuffered" argument to shell functions, which causes the output to be logged as it arrives instead of all at the end.
Some of the changes I had in the
runasprepo were actually not specific to the aspect pipeline. They were changes to be able to see output in real time (to check things were working right away). Instead of making them there, better to make them here.Interface impacts
Testing
Unit tests
Unit tests include new tests for the new feature (3 tests parametrized by 2, 6 new tests total).
Independent check of unit tests by Jean
Functional tests
Tests are covered in unit tests, but if you want to see it in action, run this in one terminal while you
tail -f test.logon another terminal: