Conversation
jeanconn
commented
Sep 16, 2025
jeanconn
commented
Sep 16, 2025
jeanconn
commented
Sep 17, 2025
This was referenced Sep 17, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run Jupiter checks.
This PR adds three new sparkles checks:
And a "wrapper" check
check_jupiter_acq_spoilers: This confirms that no acquisition search box contains the columns within 15 pixels of the Jupiter position at acquisition. (TBD - add maneuver error to check?)
check_jupiter_track_spoilers: This confirms that no fid light or guide star is within 15 pixels in column of Jupiter during the duration of the observation.
check_jupiter_distribution: This confirms that there are always at least two guide stars on the "side" of the CCD opposite Jupiter.
check_run_jupiter_checks: This runs the above three checks if Jupiter is on the CCD and adds an info message that the Jupiter checks have run. If Jupiter is not on the CCD during the observation but is in the target name, this adds a critical warning (not 100% an ACA issue, but if Jupiter was supposed to be there, something is wrong with the attitude).
For speed, the Jupiter checks are only run if Jupiter is in the target name. These methods use proseco.jupiter code as applicable.
Requires
proseco: Consider jupiter in selection
the proseco PR requires the cheta stk PR sot/cheta#257 so both need to be available for unit testing sparkles.
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
New unit tests.
As a test of both proseco and sparkles, I ran a test for "what if we needed to observe Jupiter every day" captured in this output:
for -3C - https://icxc.cfa.harvard.edu/aspect/test_review_outputs/sparkles/pr223/
for -10C - https://icxc.cfa.harvard.edu/aspect/test_review_outputs/sparkles/pr223/minus10/