Update test regress vals for chandra_aca coord improvements#228
Merged
Update test regress vals for chandra_aca coord improvements#228
Conversation
Contributor
Author
|
@taldcroft what do you think? Do I need to inspect and justify these updates more? For example the small changes in P2 I can hand-wave past saying that marginalized probabilities can be changed by the different calculation of the position on the CCD, but I don't know if we need to confirm which component of the probably changed for each test. |
5 tasks
taldcroft
approved these changes
Mar 26, 2026
Member
taldcroft
left a comment
There was a problem hiding this comment.
Looks fine. It is never ideal to see a discrete change like in the roll intervals, but we accept that these things are little finicky and have hard boundaries that can (and do) get crossed with small changes in inputs.
This was referenced Apr 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update test regress vals for chandra_aca coord changes due to sot/chandra_aca#202.
It isn't immediately expected to me that one of the roll option intervals went away on one of the tests, but it is perfectly plausible that with small coordinate changes enough of the scenario can change to have an impact.
Requires
sot/chandra_aca#202
also tested with sot/proseco#414
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.