Skip to content

Update test regress vals for chandra_aca coord improvements#228

Merged
jeanconn merged 3 commits intomasterfrom
improve-coords
Mar 26, 2026
Merged

Update test regress vals for chandra_aca coord improvements#228
jeanconn merged 3 commits intomasterfrom
improve-coords

Conversation

@jeanconn
Copy link
Copy Markdown
Contributor

@jeanconn jeanconn commented Mar 17, 2026

Description

Update test regress vals for chandra_aca coord changes due to sot/chandra_aca#202.

It isn't immediately expected to me that one of the roll option intervals went away on one of the tests, but it is perfectly plausible that with small coordinate changes enough of the scenario can change to have an impact.

Requires

sot/chandra_aca#202
also tested with sot/proseco#414

Interface impacts

Testing

Unit tests

  • Mac
(ska3-latest) flame:sparkles jean$ git rev-parse HEAD
1828101ff1d57ad487974162eb2da9154749be83
(ska3-latest) flame:sparkles jean$ env PYTHONPATH=/Users/jean/git/chandra_aca:/Users/jean/git/proseco pytest --pdb
========================================================================================= test session starts ==========================================================================================
platform darwin -- Python 3.13.11, pytest-9.0.2, pluggy-1.6.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: anyio-4.12.1, timeout-2.4.0
collected 128 items                                                                                                                                                                                    

sparkles/tests/test_checks.py ..................................................................................................                                                                 [ 76%]
sparkles/tests/test_find_er_catalog.py .....                                                                                                                                                     [ 80%]
sparkles/tests/test_review.py .....................                                                                                                                                              [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                                                                                                [100%]

========================================================================================= 128 passed in 39.27s

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@jeanconn jeanconn requested a review from taldcroft March 17, 2026 20:01
@jeanconn
Copy link
Copy Markdown
Contributor Author

@taldcroft what do you think? Do I need to inspect and justify these updates more? For example the small changes in P2 I can hand-wave past saying that marginalized probabilities can be changed by the different calculation of the position on the CCD, but I don't know if we need to confirm which component of the probably changed for each test.

Copy link
Copy Markdown
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. It is never ideal to see a discrete change like in the roll intervals, but we accept that these things are little finicky and have hard boundaries that can (and do) get crossed with small changes in inputs.

@jeanconn jeanconn merged commit 93e0cfb into master Mar 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants