Skip to content

set exit code 0 at the end #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javierggt wants to merge 1 commit into from
Closed

set exit code 0 at the end #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions starcheck/src/starcheck.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,3 +1301,5 @@ =head1 AUTHOR

=cut

exit 0
Copy link
Copy Markdown
Member

@taldcroft taldcroft Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be at the end of the END {} block above the docs.

Copy link
Copy Markdown
Contributor

@jeanconn jeanconn Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with that, I think, is that END still runs after an unexpected "die", so you get zero exit status even on a failure.

Copy link
Copy Markdown
Member

@taldcroft taldcroft Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point. Sorry, never mind.

Copy link
Copy Markdown
Contributor

@jeanconn jeanconn Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe

END {
   my $exit_status = $?;
   ...
   exit($exit_status);
}