Conversation
|
@taldcroft it looks like there is at least one (new?) ruff check here that we might want to ignore |
|
We've updated the ska3 template ruff-base to at least ignore PLC0415 (so ruff-base.toml could be updated from that reference file as a first step). |
|
@jzuhone - I gave this a spin and everything worked with one minor exception: I don't understand "Moved the "fit status" to the status bar at the bottom of the main window". I did a fit of the ACA model and I can't see anything like "fit status" in the window. Am I just missing something? Otherwise, this is awesome work! |
|
(Though the ruff issue should be cleaned up). |
|
@taldcroft most of the ruff changes were satisfied by running |

Description
This PR adds a number of enhancements to
xija_gui_fit, cleans up the code a little, and adds documentation. The extensive list of new features is:I have added complete documentation for
xija_gui_fitin this PR as well, which also is the best place to take a look at the new features. I have a rendered version of the docs up at https://cxc.cfa.harvard.edu/acis/xija/gui_fit.html.Otherwise, I made some stylistic / cleanup / bugfix changes:
objectXijaModelwas being added as an attribute to a number of subclasses when it wasn't necessary, tried to pare this downsuper().__init__().ideadirectory to.gitignorehelpstring in theArgumentParserInterface impacts
Technically speaking, given that
xija_gui_fitis a "graphical user interface", there are lots of interface changes, but they are all documented here, and since it only fits thermal models, nothing here affects flight operations immediately or directly.Testing
Unit tests are not really feasible for
xija_gui_fit, so we must rely on extensive functional testing.Unit tests
Functional tests
Carried out a full fitting workflow on both macOS and Linux, exercising all options.