Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,17 @@ and mitigation vertical slice:
- Deterministic revoke-role impact analysis with stable result hashing
- Ranked, evidence-backed replacement recommendations
- Persisted parent/child mitigation simulations with idempotent replay
- Stateless impact and mitigation previews for user-built draft organizations
- Draft recommendations that verify eligibility and workflow recovery after the
proposed role assignment, even when the candidate does not already have the
access that the new role would grant
- Before-and-after workflow comparison in the UI
- Interactive focused impact graph with removed, blocked, degraded, added, and
restored relationship states
- Interactive impact map where teams, members, roles, responsibilities, and
workflows reveal their complete connected paths and contextual test actions
- Workflow-focused and full-organization views with removed, blocked, degraded,
candidate, and restored relationship states
- Direct member selection for inspecting and testing recommended, alternative,
or excluded replacements without changing the organization baseline
- Selectable graph nodes, original/mitigation toggling, and an accessible text
representation of every relationship path
- Flyway-managed relational schema and Harborline Commerce seed
Expand Down Expand Up @@ -76,6 +84,11 @@ impact.
- `GET /api/v1/simulations/{simulationId}` retrieves an immutable saved result.
- `POST /api/v1/simulations/{simulationId}/branches` tests and saves a
recommendation as a child mitigation simulation.
- `POST /api/v1/workspaces/{workspaceId}/impact-previews` tests a role removal
against the current draft without changing it.
- `POST /api/v1/workspaces/{workspaceId}/impact-previews/mitigations` verifies a
user-selected replacement against the same draft snapshot and returns the
original and mitigated outcomes for comparison.
- `GET /api/v1/health` reports API availability.

## Tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -789,17 +789,9 @@ private static RecommendationOutcome recommendMitigations(
}

var candidatePermissions = baselinePermissions.getOrDefault(candidate.id(), Set.of());
var missingApplications = relevantApplications.stream()
.filter(application -> !hasApplicationAccess(snapshot, candidatePermissions, application.id()))
var existingApplicationAccess = relevantApplications.stream()
.filter(application -> hasApplicationAccess(snapshot, candidatePermissions, application.id()))
.toList();
if (!missingApplications.isEmpty()) {
exclusions.add(new CandidateExclusion(
new EntityRef(candidate.id(), candidate.name()),
List.of(new CandidateExclusionReason(
CandidateExclusionReasonCode.MISSING_RELEVANT_APPLICATION_ACCESS,
"Missing existing access to: " + joinedNames(missingApplications)))));
continue;
}

var branchAssignments = copyAssignments(revokedAssignments);
branchAssignments.computeIfAbsent(candidate.id(), ignored -> new LinkedHashSet<>()).add(roleId);
Expand Down Expand Up @@ -842,7 +834,7 @@ private static RecommendationOutcome recommendMitigations(
safeCandidates.add(new CandidateEvaluation(
candidate,
gainedPermissionIds,
relevantApplications,
existingApplicationAccess,
restoredWorkflows,
restoredWorkflowSteps,
sourceEmployee.teamId().equals(candidate.teamId()),
Expand All @@ -863,7 +855,9 @@ private static RecommendationOutcome recommendMitigations(
var candidate = orderedCandidates.get(index);
var evidence = new ArrayList<RecommendationEvidence>();
evidence.add(RecommendationEvidence.ACTIVE_EMPLOYEE);
evidence.add(RecommendationEvidence.EXISTING_RELEVANT_APPLICATION_ACCESS);
if (candidate.existingApplicationAccess().size() == relevantApplications.size()) {
evidence.add(RecommendationEvidence.EXISTING_RELEVANT_APPLICATION_ACCESS);
}
evidence.add(RecommendationEvidence.AFFECTED_STEP_CONSTRAINTS_SATISFIED);
if (candidate.differentActorsSatisfied()) {
evidence.add(RecommendationEvidence.DIFFERENT_ACTORS_SATISFIED);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,11 @@ public ImpactResult create(
@Valid @RequestBody DraftImpactPreviewRequest request) {
return service.preview(workspaceId, request);
}

@PostMapping("/mitigations")
public DraftMitigationPreviewResource createMitigation(
@PathVariable UUID workspaceId,
@Valid @RequestBody DraftMitigationPreviewRequest request) {
return service.previewMitigation(workspaceId, request);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package com.roleimpact.workspace.preview.api;

import java.util.UUID;

import jakarta.validation.constraints.NotNull;

public record DraftMitigationPreviewRequest(
@NotNull UUID memberId,
@NotNull UUID roleId,
@NotNull UUID replacementMemberId) {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package com.roleimpact.workspace.preview.api;

import com.roleimpact.impactengine.ImpactResult;

public record DraftMitigationPreviewResource(
ImpactResult original,
ImpactResult mitigation) {
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@
import com.roleimpact.impactengine.ImpactEngine;
import com.roleimpact.impactengine.ImpactResult;
import com.roleimpact.impactengine.InvalidImpactChangeException;
import com.roleimpact.impactengine.RevokeAndAssignEmployeeRole;
import com.roleimpact.impactengine.RevokeEmployeeRole;
import com.roleimpact.workspace.application.WorkspaceNotFoundException;
import com.roleimpact.workspace.editor.application.PublishedWorkspaceMutationException;
import com.roleimpact.workspace.editor.persistence.DraftCatalogRepository;
import com.roleimpact.workspace.preview.api.DraftImpactPreviewRequest;
import com.roleimpact.workspace.preview.api.DraftMitigationPreviewRequest;
import com.roleimpact.workspace.preview.api.DraftMitigationPreviewResource;

import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
Expand All @@ -33,13 +36,35 @@ public DraftImpactPreviewService(

@Transactional(readOnly = true)
public ImpactResult preview(UUID workspaceId, DraftImpactPreviewRequest request) {
validateDraftAssignment(workspaceId, request.memberId(), request.roleId());
var snapshot = snapshotAssembler.assemble(workspaceId);
return impactEngine.analyze(snapshot, new RevokeEmployeeRole(request.memberId(), request.roleId()));
}

@Transactional(readOnly = true)
public DraftMitigationPreviewResource previewMitigation(
UUID workspaceId,
DraftMitigationPreviewRequest request) {
validateDraftAssignment(workspaceId, request.memberId(), request.roleId());
var snapshot = snapshotAssembler.assemble(workspaceId);
var original = impactEngine.analyze(
snapshot,
new RevokeEmployeeRole(request.memberId(), request.roleId()));
var mitigation = impactEngine.analyze(
snapshot,
new RevokeAndAssignEmployeeRole(
request.memberId(),
request.roleId(),
request.replacementMemberId()));
return new DraftMitigationPreviewResource(original, mitigation);
}

private void validateDraftAssignment(UUID workspaceId, UUID memberId, UUID roleId) {
String status = catalogRepository.findWorkspaceStatus(workspaceId)
.orElseThrow(() -> new WorkspaceNotFoundException(workspaceId));
if (!"DRAFT".equals(status)) throw new PublishedWorkspaceMutationException();
if (!catalogRepository.assignmentExists(workspaceId, request.memberId(), request.roleId())) {
if (!catalogRepository.assignmentExists(workspaceId, memberId, roleId)) {
throw new InvalidImpactChangeException("The selected member does not currently hold this role");
}
var snapshot = snapshotAssembler.assemble(workspaceId);
return impactEngine.analyze(snapshot, new RevokeEmployeeRole(request.memberId(), request.roleId()));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import java.util.UUID;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;

import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -173,6 +174,37 @@ void buildsTeamsMembersAndRolesInsideADraftOnly() throws Exception {
UUID memberId = UUID.fromString(objectMapper.readTree(memberResponse.getResponse().getContentAsString())
.path("members").get(0).path("id").asText());

var candidateResponse = mockMvc.perform(post("/api/v1/workspaces/{workspaceId}/catalog/members", workspaceId)
.contentType(MediaType.APPLICATION_JSON)
.content("""
{
"teamId":"%s", "name":"Arjun Mehta", "status":"ACTIVE",
"region":"NORTH_AMERICA", "shift":"DAY"
}
""".formatted(teamId)))
.andExpect(status().isOk())
.andExpect(jsonPath("$.teams[0].memberCount").value(2))
.andReturn();
UUID candidateId = findId(
objectMapper.readTree(candidateResponse.getResponse().getContentAsString()),
"members",
"Arjun Mehta");
var inactiveCandidateResponse = mockMvc.perform(post("/api/v1/workspaces/{workspaceId}/catalog/members", workspaceId)
.contentType(MediaType.APPLICATION_JSON)
.content("""
{
"teamId":"%s", "name":"Dylan Moore", "status":"INACTIVE",
"region":"NORTH_AMERICA", "shift":"DAY"
}
""".formatted(teamId)))
.andExpect(status().isOk())
.andExpect(jsonPath("$.teams[0].memberCount").value(3))
.andReturn();
UUID inactiveCandidateId = findId(
objectMapper.readTree(inactiveCandidateResponse.getResponse().getContentAsString()),
"members",
"Dylan Moore");

var roleResponse = mockMvc.perform(post("/api/v1/workspaces/{workspaceId}/catalog/roles", workspaceId)
.contentType(MediaType.APPLICATION_JSON)
.content("""
Expand All @@ -187,19 +219,23 @@ void buildsTeamsMembersAndRolesInsideADraftOnly() throws Exception {
UUID roleId = UUID.fromString(objectMapper.readTree(roleResponse.getResponse().getContentAsString())
.path("roles").get(0).path("id").asText());

mockMvc.perform(put("/api/v1/workspaces/{workspaceId}/catalog/members/{memberId}/roles", workspaceId, memberId)
var assignmentResponse = mockMvc.perform(put("/api/v1/workspaces/{workspaceId}/catalog/members/{memberId}/roles", workspaceId, memberId)
.contentType(MediaType.APPLICATION_JSON)
.content("{\"roleIds\":[\"" + roleId + "\"]}"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.members[0].roleIds[0]").value(roleId.toString()))
.andExpect(jsonPath("$.roles[0].memberCount").value(1));
.andExpect(jsonPath("$.roles[0].memberCount").value(1))
.andReturn();
assertThat(findById(
objectMapper.readTree(assignmentResponse.getResponse().getContentAsString()),
"members",
memberId).path("roleIds").get(0).asText()).isEqualTo(roleId.toString());

mockMvc.perform(put("/api/v1/workspaces/{workspaceId}/catalog/teams/{teamId}", workspaceId, teamId)
.contentType(MediaType.APPLICATION_JSON)
.content("{\"name\":\"Platform Operations\",\"department\":\"Technology\"}"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.teams[0].name").value("Platform Operations"));
mockMvc.perform(put("/api/v1/workspaces/{workspaceId}/catalog/members/{memberId}", workspaceId, memberId)
var updatedMemberResponse = mockMvc.perform(put("/api/v1/workspaces/{workspaceId}/catalog/members/{memberId}", workspaceId, memberId)
.contentType(MediaType.APPLICATION_JSON)
.content("""
{
Expand All @@ -209,7 +245,11 @@ void buildsTeamsMembersAndRolesInsideADraftOnly() throws Exception {
}
""".formatted(teamId)))
.andExpect(status().isOk())
.andExpect(jsonPath("$.members[0].name").value("Maya Patel"));
.andReturn();
assertThat(findById(
objectMapper.readTree(updatedMemberResponse.getResponse().getContentAsString()),
"members",
memberId).path("name").asText()).isEqualTo("Maya Patel");
mockMvc.perform(put("/api/v1/workspaces/{workspaceId}/catalog/roles/{roleId}", workspaceId, roleId)
.contentType(MediaType.APPLICATION_JSON)
.content("""
Expand Down Expand Up @@ -260,7 +300,7 @@ void buildsTeamsMembersAndRolesInsideADraftOnly() throws Exception {
assertThat(countForOrganization("permissions", workspaceId)).isEqualTo(2);
assertThat(countForOrganization("capabilities", workspaceId)).isEqualTo(2);

mockMvc.perform(post("/api/v1/workspaces/{workspaceId}/impact-previews", workspaceId)
var previewResponse = mockMvc.perform(post("/api/v1/workspaces/{workspaceId}/impact-previews", workspaceId)
.contentType(MediaType.APPLICATION_JSON)
.content("""
{"memberId":"%s","roleId":"%s"}
Expand All @@ -272,7 +312,47 @@ void buildsTeamsMembersAndRolesInsideADraftOnly() throws Exception {
.andExpect(jsonPath("$.changeSet.employee.name").value("Maya Patel"))
.andExpect(jsonPath("$.changeSet.role.name").value("Production Release Manager"))
.andExpect(jsonPath("$.workflowImpacts[0].workflowName").value("Production Deployment"))
.andExpect(jsonPath("$.workflowImpacts[0].scenarioStatus").value("BLOCKED"));
.andExpect(jsonPath("$.workflowImpacts[0].scenarioStatus").value("BLOCKED"))
.andExpect(jsonPath("$.recommendations[0].candidate.id").value(candidateId.toString()))
.andReturn();
assertThat(objectMapper.readTree(previewResponse.getResponse().getContentAsString())
.path("recommendations").get(0).path("id").asText()).isNotBlank();

mockMvc.perform(post("/api/v1/workspaces/{workspaceId}/impact-previews/mitigations", workspaceId)
.contentType(MediaType.APPLICATION_JSON)
.content("""
{
"memberId":"%s", "roleId":"%s", "replacementMemberId":"%s"
}
""".formatted(memberId, roleId, candidateId)))
.andExpect(status().isOk())
.andExpect(jsonPath("$.original.overallSeverity").value("CRITICAL"))
.andExpect(jsonPath("$.mitigation.overallSeverity").value("LOW"))
.andExpect(jsonPath("$.mitigation.changeSet.replacementEmployee.id").value(candidateId.toString()))
.andExpect(jsonPath("$.mitigation.executiveSummary.workflowsBlocked").value(0))
.andExpect(jsonPath("$.mitigation.workflowImpacts[0].scenarioStatus").value("DEGRADED"));

mockMvc.perform(post("/api/v1/workspaces/{workspaceId}/impact-previews/mitigations", workspaceId)
.contentType(MediaType.APPLICATION_JSON)
.content("""
{
"memberId":"%s", "roleId":"%s", "replacementMemberId":"%s"
}
""".formatted(memberId, roleId, inactiveCandidateId)))
.andExpect(status().isOk())
.andExpect(jsonPath("$.mitigation.changeSet.replacementEmployee.id").value(inactiveCandidateId.toString()))
.andExpect(jsonPath("$.mitigation.overallSeverity").value("CRITICAL"))
.andExpect(jsonPath("$.mitigation.executiveSummary.workflowsBlocked").value(1));

var catalogAfterMitigation = mockMvc.perform(get("/api/v1/workspaces/{workspaceId}/catalog", workspaceId))
.andExpect(status().isOk())
.andReturn();
var catalogAfterMitigationJson = objectMapper.readTree(
catalogAfterMitigation.getResponse().getContentAsString());
assertThat(findById(catalogAfterMitigationJson, "members", memberId).path("roleIds"))
.extracting(JsonNode::asText)
.containsExactly(roleId.toString());
assertThat(findById(catalogAfterMitigationJson, "members", candidateId).path("roleIds")).isEmpty();

mockMvc.perform(delete("/api/v1/workspaces/{workspaceId}/catalog/teams/{teamId}", workspaceId, teamId))
.andExpect(status().isConflict())
Expand All @@ -296,6 +376,10 @@ void buildsTeamsMembersAndRolesInsideADraftOnly() throws Exception {
.andExpect(jsonPath("$.members[0].roleIds").isEmpty());
mockMvc.perform(delete("/api/v1/workspaces/{workspaceId}/catalog/members/{memberId}", workspaceId, memberId))
.andExpect(status().isOk());
mockMvc.perform(delete("/api/v1/workspaces/{workspaceId}/catalog/members/{memberId}", workspaceId, candidateId))
.andExpect(status().isOk());
mockMvc.perform(delete("/api/v1/workspaces/{workspaceId}/catalog/members/{memberId}", workspaceId, inactiveCandidateId))
.andExpect(status().isOk());
mockMvc.perform(delete("/api/v1/workspaces/{workspaceId}/catalog/teams/{teamId}", workspaceId, teamId))
.andExpect(status().isOk())
.andExpect(jsonPath("$.teams").isEmpty());
Expand All @@ -316,6 +400,16 @@ private UUID findId(com.fasterxml.jackson.databind.JsonNode root, String collect
throw new IllegalArgumentException(name + " was not found in " + collection);
}

private com.fasterxml.jackson.databind.JsonNode findById(
com.fasterxml.jackson.databind.JsonNode root,
String collection,
UUID id) {
for (var item : root.path(collection)) {
if (id.toString().equals(item.path("id").asText())) return item;
}
throw new IllegalArgumentException(id + " was not found in " + collection);
}

private void assertPreview(
UUID workspaceId,
UUID memberId,
Expand Down
Loading
Loading