Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,7 @@ public void testFailureScannerWithKeys() throws IOException {
reader.createScannerByKey("aaa".getBytes(), "zzz".getBytes());
Assert
.fail("Failed to catch creating scanner with keys on unsorted file.");
}
catch (RuntimeException e) {
}
finally {
} finally {
reader.close();
}
}
Expand Down Expand Up @@ -192,33 +189,21 @@ public void testFailureSeek() throws IOException {
try {
scanner.lowerBound("keyN".getBytes());
Assert.fail("Cannot search in a unsorted TFile!");
}
catch (Exception e) {
// noop, expecting excetions
}
finally {
} finally {
}

// can't find higher
try {
scanner.upperBound("keyA".getBytes());
Assert.fail("Cannot search higher in a unsorted TFile!");
}
catch (Exception e) {
// noop, expecting excetions
}
finally {
} finally {
}

// can't seek
try {
scanner.seekTo("keyM".getBytes());
Assert.fail("Cannot search a unsorted TFile!");
}
catch (Exception e) {
// noop, expecting excetions
}
finally {
} finally {
}
}
finally {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,6 @@ private void closeResponder() {
try {
response.close();
response.join();
} catch (InterruptedException e) {
} finally {
response = null;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ private static void tryRead(Configuration conf, LocatedBlock lblock,
if (s != null) {
try {
s.close();
} catch (IOException iex) {
} finally {
s = null;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,16 @@ public void testClusterWithYarnClientProtocolProvider() throws Exception {

}

try {
conf = new Configuration();
conf.set(MRConfig.FRAMEWORK_NAME, MRConfig.YARN_FRAMEWORK_NAME);
cluster = new Cluster(conf);
ClientProtocol client = cluster.getClient();
assertTrue(client instanceof YARNRunner);
} catch (IOException e) {

} finally {
if (cluster != null) {
cluster.close();
}
try {
conf = new Configuration();
conf.set(MRConfig.FRAMEWORK_NAME, MRConfig.YARN_FRAMEWORK_NAME);
cluster = new Cluster(conf);
ClientProtocol client = cluster.getClient();
assertTrue(client instanceof YARNRunner);
} finally {
if (cluster != null) {
cluster.close();
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ public void initialize(Configuration conf, ResourceUsageMetrics metrics,

touchPath = getFilePath(getIdentifier());
fs.delete(touchPath, false);
} catch (Exception e) {

} finally {
if (fs != null) {
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,6 @@ public void testBadChunks() throws Exception {
try {
in = new DataInputStream(new FileInputStream(fn));
vout = vf.verifyFile(byteAm, in);
} catch (Exception e) {

} finally {
if(in != null) in.close();
}
Expand Down