chore: migrate notifications subscriber to v2#114
Merged
Conversation
The Sourcegraph monorepo cannot clear the Pub/Sub v1 deprecation while the accounts SDK still imports the old module from its notifications subscriber package. Move that package to the supported v2 client API so downstream consumers can stop pulling v1 through this SDK. Amp-Thread-ID: https://ampcode.com/threads/T-019f3bcb-5412-74e1-ba13-00bf117a1409 Co-authored-by: Amp <amp@ampcode.com>
Member
Author
|
CI failure unrelated. Edit: probably related to the go.mod version bump, fixing the workflows in this PR |
The Pub/Sub v2 migration raises the module's Go target to 1.25, but the prebuilt golangci-lint v1 binary selected by the existing action is built with Go 1.24 and refuses to load the config. Keep the current lint configuration and action generation, but build the linter from source using the workflow Go toolchain so it can analyze the newer module target. Amp-Thread-ID: https://ampcode.com/threads/T-019f3bcb-5412-74e1-ba13-00bf117a1409 Co-authored-by: Amp <amp@ampcode.com>
keegancsmith
commented
Jul 7, 2026
keegancsmith
changed the title
jac
approved these changes
Jul 7, 2026
Member
Author
|
Ok
this will never land since it no longer exists. Will force landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates the notifications subscriber package from the deprecated
cloud.google.com/go/pubsubmodule tocloud.google.com/go/pubsub/v2.