add favicon#3
Open
Hellebore wants to merge 6 commits into
Open
Conversation
Author
|
This pull request was cloned from Note: the URL is not a link to avoid triggering a notification on the original pull request. |
Hellebore
commented
Mar 21, 2024
Author
There was a problem hiding this comment.
Hey @Hellebore - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
+7
to
+10
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | ||
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | ||
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | ||
| <link rel="manifest" href="/site.webmanifest"> |
Author
There was a problem hiding this comment.
The stylesheet link uses a relative path, while favicon links use root-relative paths. Consider aligning the path usage for consistency and maintainability.
Suggested change
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | |
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | |
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | |
| <link rel="manifest" href="/site.webmanifest"> | |
| <link rel="apple-touch-icon" sizes="180x180" href="https://xorol.github.io/apple-touch-icon.png"> | |
| <link rel="icon" type="image/png" sizes="32x32" href="https://xorol.github.io/favicon-32x32.png"> | |
| <link rel="icon" type="image/png" sizes="16x16" href="https://xorol.github.io/favicon-16x16.png"> | |
| <link rel="manifest" href="https://xorol.github.io/site.webmanifest"> |
Comment on lines
+9
to
+12
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | ||
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | ||
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | ||
| <link rel="manifest" href="/site.webmanifest"> |
Author
There was a problem hiding this comment.
While adding favicons enhances brand visibility, review if it's necessary for all pages, especially if some are not frequently accessed directly.
Suggested change
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | |
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | |
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | |
| <link rel="manifest" href="/site.webmanifest"> | |
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | |
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | |
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | |
| <link rel="manifest" href="/site.webmanifest" type="application/manifest+json"> |
Comment on lines
+5
to
+8
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | ||
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | ||
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | ||
| <link rel="manifest" href="/site.webmanifest"> |
Author
There was a problem hiding this comment.
Ensure the server correctly serves the site.webmanifest file with the 'application/manifest+json' MIME type for optimal compatibility.
Suggested change
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | |
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | |
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | |
| <link rel="manifest" href="/site.webmanifest"> | |
| <!-- Consider the necessity of these favicons for performance optimization. If this page is not directly accessed often, you might opt to include these only on your main entry pages. --> | |
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"> | |
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | |
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | |
| <link rel="manifest" href="/site.webmanifest"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.