fix: typo, broken highlights, duplicate SEC-06 header#92
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Fix 'Crypographically' → 'Cryptographically' in testimonials - Replace hardcoded highlight list with JSON-driven highlight field (removes phantom entries NIP-54 and Window.nostr.db that matched no project; adds npub.cash and NIP-61 to highlight field in JSON) - Remove duplicate SEC-06 heading from CTA section (SEC-06 now has real projects so the hardcoded header was duplicated)
1d70a0e to
b11ca56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes:
1. Typo in testimonials section
'Crypographically signed' → 'Cryptographically signed'
2. Broken highlights system
The project highlights on
/projectsused a hardcoded array inProjectShowcase.astrothat was out of sync with the data:Window.nostrdb.js) — silently failed to renderhighlight: truein JSON but missing from the hardcoded listFix: replaced the hardcoded array with
projects.filter(p => p.highlight), so highlights are now driven entirely by the JSON field. Addedhighlight: trueto npub.cash and NIP-61 to match what was intended.3. Duplicate SEC-06 header
The CTA section at the bottom had a hardcoded 'SEC-06' heading. Now that SEC-06 has real projects, this created a duplicate. Removed the hardcoded heading — the CTA ('Your Project Here') still shows without it.