fix: Remove tooltip from enquiry modal close button#2673
Closed
RabbiIslamRony wants to merge 4 commits intosovware:developmentfrom
Closed
fix: Remove tooltip from enquiry modal close button#2673RabbiIslamRony wants to merge 4 commits intosovware:developmentfrom
RabbiIslamRony wants to merge 4 commits intosovware:developmentfrom
Conversation
- Use isDismissible={false} to disable default WordPress Modal close button
- Implement custom close button without tooltip
- Add minimal useEffect to move button to modal header
- Remove margin-top from modal content for better spacing
- Optimize code using modern JavaScript best practices
Uses WordPress Modal API (isDismissible) for clean solution.
Custom button positioned in header without any tooltip text.
Fixes: Tooltip display issue when hovering over modal close button
…ose button using WordPress Modal API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
Removes unwanted "Close" tooltip from enquiry modal close button using WordPress Modal API.
Solution:
isDismissible={false}to disable default WordPress Modal close buttonuseEffectto position button in modal headerApproach:
Uses WordPress Modal's native
isDismissibleAPI instead of hiding tooltips, following senior developer's recommendation for a cleaner solution.How to test
Any linked issues
Fixes tooltip display issue in enquiry details modal close button.
Checklist