Security audit remediation - #1
Merged
Merged
Conversation
…ind metrics to loopback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security audit remediation. Findings came from a multi-dimension audit (auth, crypto, HTTP handlers, cluster) plus govulncheck. Each fix has a regression test where behavior changed; full suite and govulncheck symbol scan are green under the pinned toolchain.
Critical
drpcserverran with no interceptor, so the HMACHandshakewas decorative: any peer reachingcluster.listencould callPutChunk,PutMetadata,Join, orBulkSyncKV(exfiltrating all S3 keys, tokens and SSE key material) unauthenticated. Added a per-connection auth gate keyed on the transport, cleaned up on close.High
admin_tokenset it is denied, unless the operator opts in viaallow_unauthenticated_admin. Was open by default.Joinis covered by the handshake gate (was unauthenticated layout mutation).aws-chunkedchunk size before allocation (wasmake([]byte, size)on an attacker-controlled header before signature check) and bounded peerPutChunkbuffering.Medium
X-Amz-Content-Sha256(single PUT already did).x-amz-decoded-content-length.Low
X-Content-Type-Options: nosniffon all responses, HSTS under TLS./statusdetail (go version, disk free, error text) gated behind the admin token.Dependencies
toolchain go1.25.13for the patched standard library (encoding/xml recursion, net/url, crypto/tls, os symlink Root escape).