Merged
Conversation
…rl parameter to existing endpoints.
|
Hi Simon! I looked over the PR. Before the govt shutdown we had discussed here that I had implemented this in our microservices already (finish_fasta_api branch) My only suggestion is to rename the cc @ctcncgr |
Contributor
Author
Done |
StevenCannon-USDA
approved these changes
Dec 17, 2025
Contributor
StevenCannon-USDA
left a comment
StevenCannon-USDA
left a comment
There was a problem hiding this comment.
Given the review from @matthewwiese, I am going to approve and merge this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds filtering by samples to the /vcf/fetch endpoint.
Samples can be given to the api with the ?samples url query parameter (e.g ?samples=PI86046?samples=PI90208?samples=PI219698)