feat(ui/search):Reimagine search flow with overlay - #357
Open
prewue wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui.mp4
Description
This PR is a reimagining of the search flow. Search is now launched from a floating overlay instead of an in-page search form, while the Search results page remains focused on results and category filtering.
AI Prompt (Optional)
AI Prompt Used
AI Tool: Claude and Codex
Type of Change
Related Issues
N/A
Changes Made
Testing
swift test --skip KasetUITests)Additional verification run locally:
swiftformat .swiftlint --strictScripts/build-app.sh debugxcodebuild test -project KasetUITests.xcodeproj -scheme KasetUITests -destination 'platform=macOS,arch=arm64' -only-testing:KasetUITests/SearchViewUITests.agents/skills/autoreview/scripts/autoreview --mode localChecklist
swiftlint --strict && swiftformat .Screenshots
N/A
Additional Notes
The targeted UI test suite launches the freshly built debug app bundle from
.build/app/Kaset.appand verifies the overlay opens, submits, closes, shows results, keeps category tabs, and does not show the old in-page search field.