Skip to content

fix: add Sign Out to account switcher popover - #384

Open
mozyonee wants to merge 2 commits into
sozercan:mainfrom
mozyonee:fix/account-switcher-sign-out
Open

fix: add Sign Out to account switcher popover#384
mozyonee wants to merge 2 commits into
sozercan:mainfrom
mozyonee:fix/account-switcher-sign-out

Conversation

@mozyonee

@mozyonee mozyonee commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Users looking for logout in the sidebar profile popover found only Guest Mode / account switch, so they felt stuck on the wrong account. Sign Out already existed in Settings; this adds the same action to the profile popover where people expect it.

AI Prompt (Optional)

🤖 AI Prompt Used
Fix GitHub issue #361: can't logout / no disconnect in profile. Add Sign Out to the account switcher popover using the existing Settings sign-out path. Keep the change minimal.

AI Tool: Cursor

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)

Related Issues

Fixes #361

Changes Made

  • Add a Sign Out row to AccountSwitcherPopover (same prepareForSignOut() + signOut() path as Settings)
  • While Guest Mode is active, only Guest Mode shows as selected (account rows stay unselected)
  • Disable the accent focus ring on the popover’s list-style content
  • Update profile accessibility hint and UI-test accessibility ID

Testing

  • swift build
  • swiftlint --strict on touched SwiftUI files
  • Manual testing performed
  • UI tested on macOS 26+

Manual checklist:

  • Profile → popover shows Sign Out
  • Sign Out returns to logged-out / login flow
  • Guest Mode selected → account rows are not checkmarked
  • Leaving Guest Mode / selecting an account restores normal selection
  • Guest Mode row no longer shows a persistent accent focus outline on open

Checklist

  • My code follows the project's style guidelines
  • I have run swiftlint --strict && swiftformat .
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally
  • I have updated documentation if needed
  • I have checked for any performance implications
  • My changes generate no new warnings

Screenshots

image

Additional Notes

Settings → General → Sign Out remains as a second entry point. Guest Mode still preserves the signed-in session (ADR-0024); only the popover selection UI treats Guest as the active choice.

@mozyonee
mozyonee marked this pull request as ready for review July 16, 2026 18:44
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@mozyonee

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cant logout

1 participant