fix: add Sign Out to account switcher popover - #384
Open
mozyonee wants to merge 2 commits into
Open
Conversation
mozyonee
marked this pull request as ready for review
July 16, 2026 18:44
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Users looking for logout in the sidebar profile popover found only Guest Mode / account switch, so they felt stuck on the wrong account. Sign Out already existed in Settings; this adds the same action to the profile popover where people expect it.
AI Prompt (Optional)
🤖 AI Prompt Used
AI Tool: Cursor
Type of Change
Related Issues
Fixes #361
Changes Made
AccountSwitcherPopover(sameprepareForSignOut()+signOut()path as Settings)Testing
swift buildswiftlint --stricton touched SwiftUI filesManual checklist:
Checklist
swiftlint --strict && swiftformat .Screenshots
Additional Notes
Settings → General → Sign Out remains as a second entry point. Guest Mode still preserves the signed-in session (ADR-0024); only the popover selection UI treats Guest as the active choice.