chore: disable some unused default features#117
Merged
JayWhite2357 merged 3 commits intospaceandtimefdn:mainfrom Aug 28, 2024
Merged
chore: disable some unused default features#117JayWhite2357 merged 3 commits intospaceandtimefdn:mainfrom
JayWhite2357 merged 3 commits intospaceandtimefdn:mainfrom
Conversation
Follow the same formatting as the other lines.
They aren't needed and prevent building for `wasm32-unknown-unknown` without the browser Javascript APIs, because one of the default features is `wasmbind`.
They aren't needed and prevent building for `wasm32-unknown-unknown` without the browser Javascript APIs, because one of the default features is `getrandom`. That feature enables the `getrandom` dependency, which can't be built for Wasm unless the Javascript APIs are enabled.
Contributor
|
Thanks @jvff! Looks good. Extra note: We will likely be removing merlin from the dependencies in the near future, so |
JayWhite2357
approved these changes
Aug 28, 2024
|
🎉 This PR is included in version 0.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
JayWhite2357
pushed a commit
that referenced
this pull request
Mar 7, 2025
# Rationale for this change To build this crate for `wasm32-unknown-unknown` to run on runtimes with a limited custom API available (e.g., Linera contracts), `wasm-bindgen` should not be a dependency. That's because `wasm-bindgen` generates bindings for the Javascript APIs available in browsers (and similar runtimes). For more bare-bones runtimes, these APIs aren't available. # What changes are included in this PR? Disabling the `default` features of `chrono`, `rand` and `rand-core`. Unfortunately, this doesn't complete the work to support `wasm32-unknown-unknown` without JS, because a fix is also needed in `merlin` (zkcrypto/merlin#8). # Are these changes tested? Tested with `cargo test`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
To build this crate for
wasm32-unknown-unknownto run on runtimes with a limited custom API available (e.g., Linera contracts),wasm-bindgenshould not be a dependency. That's becausewasm-bindgengenerates bindings for the Javascript APIs available in browsers (and similar runtimes). For more bare-bones runtimes, these APIs aren't available.What changes are included in this PR?
Disabling the
defaultfeatures ofchrono,randandrand-core.Unfortunately, this doesn't complete the work to support
wasm32-unknown-unknownwithout JS, because a fix is also needed inmerlin(zkcrypto/merlin#8).Are these changes tested?
Tested with
cargo test.