Skip to content

added 2 new rules and other changes in db, ingress and deployments - #231

Open
shubham4443 wants to merge 11 commits into
spacecloud-io:v0.22.0-oldfrom
shubham4443:security-builder
Open

added 2 new rules and other changes in db, ingress and deployments#231
shubham4443 wants to merge 11 commits into
spacecloud-io:v0.22.0-oldfrom
shubham4443:security-builder

Conversation

@shubham4443

Copy link
Copy Markdown
Contributor

No description provided.

@YourTechBud
YourTechBud changed the base branch from v0.21.0 to v0.22.0 January 25, 2021 11:49

@YourTechBud YourTechBud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham4443 lets get on a video call where you can demo me what you've done

<Form.Item name='f2' rules={[{ required: true }, { validator: createValueAndTypeValidator(type, true) }]}>
<ObjectAutoComplete placeholder="Second operand" options={autoCompleteOptions} />
</Form.Item>
<>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

return
}
if (selectedRuleObj.rule === "query" || selectedRuleObj.rule === "force" || selectedRuleObj.rule === "remove" || selectedRuleObj.rule === "encrypt" || selectedRuleObj.rule === "decrypt" || selectedRuleObj.rule === "hash") {
if (selectedRuleObj.rule === "query" || selectedRuleObj.rule === "force" || selectedRuleObj.rule === "remove" || selectedRuleObj.rule === "encrypt" || selectedRuleObj.rule === "decrypt" || selectedRuleObj.rule === "hash" || selectedRuleObj.rule === "graphql") {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need a clause for the graphql rule

graph.edges.push({ from: id, to: `${id}.clauses.${len}` })
}
if (rule.rule === "query" || rule.rule === "force" || rule.rule === "remove" || rule.rule === "encrypt" || rule.rule === "decrypt" || rule.rule === "hash") {
if (rule.rule === "query" || rule.rule === "force" || rule.rule === "remove" || rule.rule === "encrypt" || rule.rule === "decrypt" || rule.rule === "hash" || rule.rule === "graphql") {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no clause in graphql rule

sharadregoti
sharadregoti previously approved these changes Jan 28, 2021
@sharadregoti

sharadregoti commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

Following changes were made in this PR

  • Trim spaces at the end and start of the ingress router URL
  • Added 2 new security rules Graphql & Transform
  • Added a clipboard for copying deployed service URL
  • In & Not In operator will multiple values & send them as an array

sharadregoti
sharadregoti previously approved these changes Jan 29, 2021
YourTechBud
YourTechBud previously approved these changes Jan 29, 2021
@shubham4443
shubham4443 dismissed stale reviews from YourTechBud and sharadregoti via 1d482b2 January 30, 2021 17:48
@sharadregoti

Copy link
Copy Markdown
Contributor

Why there is no autocomplete when I load fields from a variable?
image

@sharadregoti

Copy link
Copy Markdown
Contributor

2:
JWT claims is a string not object, refer webhook security rule
image

3:
Graphql variables are not mandatory.
image

@sharadregoti

Copy link
Copy Markdown
Contributor

4:
Request template is not optional in transform security rule
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants