feat(ci): publish binaries for linux/amd64 and linux/arm64 on release#94
Conversation
… macos/arm64 on release
|
Nice work — the native ARM64 runner is the right call and the fork-friendly registry path is a good touch. A few suggestions that might help get this merged:
|
|
@Marenz That way, whatever dirty work I make on the journey (the PR is the journey), the only commit that matters is the squashed commit on Working on the rest, though. Thanks for the feedback ❤️ |
|
@Marenz, updated according to your suggestions, except for squashing. LMK if you really want this PR squashed. There is no How do you review code? I find it odd to review individual commits, the thing that matters to me is the diff that enters main, regardless of how we got there. So, when I review, I just check the diff, and maybe the diff since last review; I don't find value in looking at individual commits by others, but maybe that's a mindset I need to change 🤔 |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
build-binariesjob to compile native binaries for Linux x86_64 and ARM64github.repository_ownerfor dynamic Docker image registry path (fork-friendly)Changes
Binary builds:
x86_64-unknown-linux-gnuonubuntu-24.04aarch64-unknown-linux-gnuonubuntu-24.04-arm(native ARM runner)protocfor Lance dependency.tar.gzand upload as release assetsDocker improvements:
ghcr.io/spacedriveapp/spacebotto dynamic${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.IMAGE_NAME }}${{ github.repository }}for similar dynamic namingConditional deployment:
github.repository_owner == 'spacedriveapp'Testing
Tested on fork: https://github.com/morgaesis/spacebot/releases/tag/v0.1.18