Skip to content

remove pkg_resources#40

Merged
stscirij merged 1 commit into
spacetelescope:masterfrom
braingram:pkg_resources
Jan 29, 2026
Merged

remove pkg_resources#40
stscirij merged 1 commit into
spacetelescope:masterfrom
braingram:pkg_resources

Conversation

@braingram
Copy link
Copy Markdown
Contributor

Closes #36

Replace pkg_resources with the more standard importlib.metadata.

@braingram braingram requested a review from a team as a code owner January 29, 2026 15:58
@braingram
Copy link
Copy Markdown
Contributor Author

@stscirij I can't request reviewers on this. Would you take a look?

Docs failure is unrelated. It's attempting to use python 3.7:

version: 3.7

which was end of life in 2023.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 10.94%. Comparing base (6a51e4b) to head (80f838a).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
costools/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   10.94%   10.94%           
=======================================
  Files           7        7           
  Lines         987      987           
  Branches      195      195           
=======================================
  Hits          108      108           
  Misses        879      879           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@stscirij stscirij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. Can you also bump the python version in the readthedocs yaml to something more current, e.g. 3.13?

@braingram
Copy link
Copy Markdown
Contributor Author

This change looks good. Can you also bump the python version in the readthedocs yaml to something more current, e.g. 3.13?

Thanks!

I'd prefer to handle that in a separate PR as I'm not sure what extra issues that will reveal.

@braingram
Copy link
Copy Markdown
Contributor Author

Looking at open PRs:
https://github.com/spacetelescope/costools/pull/24/changes
already bumps it to 3.11

Copy link
Copy Markdown
Contributor

@stscirij stscirij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, approved

@braingram
Copy link
Copy Markdown
Contributor Author

Thanks again. I am unable to merge so please feel free to do so when you see fit.

@stscirij stscirij merged commit 58422d3 into spacetelescope:master Jan 29, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error running tests on Python 3.12

2 participants