Bugfix#409
Open
sanjibs wants to merge 2 commits into
Open
Conversation
(x_idl, y_idl) correspond to (y, z) components of the unit vector respectively.
Did not work if any element of x_rad, y_rad, z_rad was zero.
tonysohn
approved these changes
Jan 16, 2026
Collaborator
tonysohn
left a comment
tonysohn
left a comment
There was a problem hiding this comment.
I approve this change. Found out the same bug while working with @Skyhawk172 .
tonysohn
approved these changes
Jan 16, 2026
Collaborator
Sorry, I need to un-approve this PR since there needs to be some changes in the submitted |
tonysohn
requested changes
Jan 20, 2026
Collaborator
tonysohn
left a comment
tonysohn
left a comment
There was a problem hiding this comment.
I found two places that need to be changed.
| # then apply 3D rotation matrix to tel | ||
| unit_vector_idl = rotations.unit_vector_from_cartesian(x=x_idl*u.arcsec, y=y_idl*u.arcsec) | ||
| unit_vector_idl = rotations.unit_vector_from_cartesian(y=x_idl*u.arcsec, z=y_idl*u.arcsec) | ||
| unit_vector_idl[1] = aperture.VIdlParity * unit_vector_idl[1] |
Collaborator
There was a problem hiding this comment.
aperture.VIdlParity should be self.VIdlParity
| if output_coordinates == 'cartesian': | ||
| x_idl_arcsec, y_idl_arcsec = unit_vector_idl[0] * u.rad.to(u.arcsec), unit_vector_idl[ | ||
| 1] * u.rad.to(u.arcsec) | ||
| unit_vector_idl[1] = aperture.VIdlParity * unit_vector_idl[1] |
Collaborator
There was a problem hiding this comment.
aperture.VIdlParity should be self.VIdlParity
Collaborator
There was a problem hiding this comment.
@sanjibs Would you be able to change these and resubmit the PR? (Sorry, I'm not familiar enough to do this from my end).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just fixes the bugs