Encode production GitLab ApplicationSettings in Terraform - #1439
Merged
Conversation
mvandenburgh
force-pushed
the
gitlab-application-settings
branch
from
August 14, 2026 16:44
5213170 to
5cf425f
Compare
mvandenburgh
marked this pull request as ready for review
August 14, 2026 16:44
Member
Author
|
Note, some of the settings that are really important for spack, |
jjnesbitt
reviewed
Aug 17, 2026
Collaborator
|
FYI @mvandenburgh I was getting an error that seemed to be due to new resources. I bumped the gitlab provider version to match our prod gitlab version. |
jjnesbitt
force-pushed
the
gitlab-application-settings
branch
2 times, most recently
from
August 26, 2026 16:28
2b2f53c to
56875bb
Compare
Adds a gitlab_application_settings resource to the spack_gitlab module with all instance settings captured from production GitLab (237 attributes supported by provider 17.6.1).
One-sentence descriptions taken from the gitlab provider 17.6.1 documentation for the gitlab_application_settings resource. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jjnesbitt
force-pushed
the
gitlab-application-settings
branch
from
August 28, 2026 18:19
bcf0570 to
b95b5e1
Compare
jjnesbitt
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a gitlab_application_settings resource to the spack_gitlab module with all instance settings (at least, those supported by the current GitLab TF provider) captured from production GitLab.
This PR is intentionally verbose and includes all application settings that exist in our database that are supported by the GitLab TF provider. The idea is to capture these now, use them to stand up the new staging instance, and then we can pare away the settings we don't care about tracking in Terraform.